Enable hacking rule E265

Bug #1391787 reported by jiangfei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
jiangfei

Bug Description

In ironic/tox.ini ignore = E12,E265,E711, we Enable hacking rule E265.

E265 : block comment should start with ‘# ‘

jiangfei (jiangfei0622)
Changed in ironic:
assignee: nobody → jiangfei (jiangfei0622)
Revision history for this message
Dmitry Tantsur (divius) wrote :

For the future: I don't think you need a separate bug for every hacking rule to enable.

Changed in ironic:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134098

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by jiangfei (<email address hidden>) on branch: master
Review: https://review.openstack.org/134098

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/133921
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=63ab84ccace23e70f1f6676bbb4418573995aa4e
Submitter: Jenkins
Branch: master

commit 63ab84ccace23e70f1f6676bbb4418573995aa4e
Author: jiangfei <email address hidden>
Date: Wed Nov 12 18:21:43 2014 +0800

    Enable hacking rule E265

     E265 is block comment should start with '# '

    Closes-Bug: #1391787

    Change-Id: I8f0e142bd14fd201da3b8c39501f9d858a5b051b

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.