alternate navigation broken

Bug #1391524 reported by Matthias Runge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Matthias Runge
Juno
Fix Released
Medium
Matthias Runge

Bug Description

horizon_dashboard_nav relies on menu organized in PanelGroups. When not using a PanelGroup, e.g in Identity dashboard, the last level of navigation is broken.

This is apparently not an issue with Accordion Navigation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133696

Changed in horizon:
assignee: nobody → Matthias Runge (mrunge)
status: New → In Progress
Revision history for this message
Matthias Runge (mrunge) wrote :

E.g Admin Panel uses an additional PanelGroup:

class SystemPanels(horizon.PanelGroup):
    slug = "admin"
    name = _("System")
    panels = ('overview', 'metering', 'hypervisors', 'aggregates',
    ¦ ¦ ¦ 'instances', 'volumes', 'flavors', 'images',
    ¦ ¦ ¦ 'networks', 'routers', 'defaults', 'info')

class Admin(horizon.Dashboard):
    name = _("Admin")
    slug = "admin"
    panels = (SystemPanels,)
    default_panel = 'overview'
    permissions = ('openstack.roles.admin',)

It should be sufficient to add panels directly to Admin instead of using SystemPanels

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/133696
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8e3950a19c244cbb253b34ef1cd46c86b952cc14
Submitter: Jenkins
Branch: master

commit 8e3950a19c244cbb253b34ef1cd46c86b952cc14
Author: Matthias Runge <email address hidden>
Date: Tue Nov 11 14:47:47 2014 +0100

    Fix dashboard nav, when panelgroup empty

    The identity dashboard breaks with a common pattern
    and doesn't use a panel group to group panels. When not
    using accordion navigation, the last level of navigation is
    not shown at all.

    Change-Id: Ic76611009eac30658d0af082b0e46cd8f2da1832
    Closes-Bug: #1391524

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/138018

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/juno)

Reviewed: https://review.openstack.org/138018
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=91447384e8cdd2767ddf64b4699cce6dc5ca03b3
Submitter: Jenkins
Branch: stable/juno

commit 91447384e8cdd2767ddf64b4699cce6dc5ca03b3
Author: Matthias Runge <email address hidden>
Date: Tue Nov 11 14:47:47 2014 +0100

    Fix dashboard nav, when panelgroup empty

    The identity dashboard breaks with a common pattern
    and doesn't use a panel group to group panels. When not
    using accordion navigation, the last level of navigation is
    not shown at all.

    Change-Id: Ic76611009eac30658d0af082b0e46cd8f2da1832
    Closes-Bug: #1391524
    (cherry picked from commit 8e3950a19c244cbb253b34ef1cd46c86b952cc14)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.