Wildcard records cannot be added, when at least one is already created

Bug #1391426 reported by Pavel Kirpichyov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Endre Karlson

Bug Description

Scenario 1:
create domain: test.com.
create record: *.test.com.
create record: mail.test.com.

Scenario 2:
create domain: test.com.
create record: mail.test.com.
create record: *.test.com.

Scenario 2 will failed at step 3, becouse find_recordset method will find previous record recordset (mail.test.com) instead of new one. The reason for this behavior is feature in sqlalchemy storage:
https://github.com/openstack/designate/blob/bc17db433cbb3f3d3c6135db5d747d5a7b0e1c94/designate/sqlalchemy/base.py#L100
which replaces * for %, but here it's wrong behavior

summary: - Wildcard records cannot be added, then at least one is already created
+ Wildcard records cannot be added, when at least one is already created
Kiall Mac Innes (kiall)
Changed in designate:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166806

Changed in designate:
assignee: nobody → Endre Karlson (endre-karlson)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/166806
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=e59271d97f82d452992337f9deff109f79e7f75f
Submitter: Jenkins
Branch: master

commit e59271d97f82d452992337f9deff109f79e7f75f
Author: Endre Karlson <email address hidden>
Date: Mon Mar 23 13:52:17 2015 +0100

    Fix handling of wildcards in api / storage

    We need to move the handling of '*' to '%' up to the API layer since if not it
    causes a issue described in the bug. This change addresses this by removing the
    replace of '*' to '%' in the storage layer to the API and also fixes any other
    places '*' is used for wildcard search.

    Closes-Bug: #1391426

    Change-Id: Ib75e8359b8040effea3dfdbf9c2baf05c3ed208b

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.