LateNight - Stacked feedback

Bug #1391345 reported by naught101
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Unassigned

Bug Description

LateNight-Stacked is an awesome skin, it's great to see the 4-deck setup in action, as well as the effects rack.

Here are some minor feedback points:

* In attached image, spacing is a bit sloppy. Getting rid of the blue areas would save a lot of space.
* If that space is saved, the waveforms could be made a bit taller.
* The left and right deck sizes change size depending on the track artist, and it's a bit disconcerting (bottom red arrow) (could be #1329272 ?)
* It would be good if all decks were different colours. Probably yellow, Blue, (Red, Green). Also, it'd be great if the mixer strips could have some colour indication as well, so it's a bit more obvious which strip belongs to which deck.
* It's no longer possible to tap the BPM meter to set the tempo, as it was in previous skins.
* I find the yellow text quite eye-straining. Something more neutral would be good, as with the original LateNight skin. Could there be a separate version for those who want yellow?
* No Mic deck.

Tags: skin
Revision history for this message
naught101 (naught101) wrote :
Revision history for this message
Owen Williams (ywwg) wrote :

Thanks for the feedback.

* I don't think it's a good idea to get rid of all the whitespace. If all the blue areas were eliminated it would be very crowded
* Left/Right deck size is a difficult problem that may require custom coding to fix
* Mic will appear if you set one up.

As for the color choices, I like it the way it is :).

I'll see what I can do about the bpm tap

Revision history for this message
naught101 (naught101) wrote :

Re: Whitespace - the problem is that it doesn't fit on small screens very well, so I was trying to minimise height. My screen is 900px high, and with 4 decks + samplers and effects, I can't see the library at all. I probably won't be using all of that at once, but even just with 4 decks, it can be a little tight browsing the library. 768px is still the most common vertical resolution for laptops, and 4 decks aren't really viable there.

Maybe it would be better to make a "compact" version though, and keep this one as-is?

Revision history for this message
Owen Williams (ywwg) wrote :

There is no way to fit 4 decks, samplers, effects, and the library in that small amount of vertical space. We could probably grab a few pixels here or there, but that's just too much stuff going on.

I would disagree that the most common vertical resolution is 768px -- 800, maybe :).

The long-term fix is having a tab-based system where the library is one tab and effects and samplers are another, but that's not possible right now. Until then, you need a higher resolution screen to do 4 decks.

If you want a compact skin, use Shade

Revision history for this message
jus (jus) wrote :

<quote>
Mic will appear if you set one up.
</quote>

Apparently this does not work with current master.
In my setup Mic 1 is configured in the preferences, but no mic sections pops up in the skins mixer section.

in Latenights microphone.xml, there is this line
<Connection>
  <ConfigKey>[Microphone],configured</ConfigKey>
  <BindProperty>visible</BindProperty>
</Connection>

Changing to <ConfigKey>[Microphone],enabled</ConfigKey> makes it work on skin reload.

What is correct?
Seems there was a discussion back then https://github.com/mixxxdj/mixxx/commit/8c0e99851acba41716d4c4d507f54946a08426c4

Revision history for this message
Owen Williams (ywwg) wrote :

Sigh. I consider that a bug. There should be a CO for "configured" meaning "this deck is hooked up to an input" and another "enabled" meaning "mic is turned on"

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Yea, it's for backwards compatibility that we kept it "enabled" rather than "configured".

"talkover" is for enabling the mic for speaking into

Changed in mixxx:
milestone: none → 1.12.0
Revision history for this message
Owen Williams (ywwg) wrote :

ah, ok. I'll fix the skin

Revision history for this message
Owen Williams (ywwg) wrote :

OK microphone widget should be fixed.

I will still work on bpm tap and whatever whitespace fixes I can manage. I think I even created a slightly-smaller rate control slider to save some height, so I can use that.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → Low
Revision history for this message
naught101 (naught101) wrote :

@ywwg: Ok, the yellow colour is growing on me. But I still think it would be really good to have 4 deck colours, instead of just 2 - in 2 deck mode, having both wavelengths above the mixer the same colour is sometimes quite difficult to read. Maybe something like these as base colours:

http://paletton.com/#uid=70V190klllluI++yq++9S00hV00

or

http://paletton.com/#uid=70Z1R0kseo5IGNnNNMUkyd5odb2

(I didn't match your yellow, but you get the idea)

Revision history for this message
Owen Williams (ywwg) wrote :

I was thinking of editing the style QSS file to make it easier to change the color scheme. It might even be possible to hook in to the existing Scheme support, though no guarantees there.

Revision history for this message
Owen Williams (ywwg) wrote :

It looks like we have to do some work to support changing skin colors. I don't want to change the colors I have chose, so I would prefer to have a proper solution for defining colors in skins (https://bugs.launchpad.net/mixxx/+bug/1402236) to address this problem. My colors are designed to resemble my controller, which has one color for decks 1 and 2 and one color for decks 3 and 4.

So for now this bug is fixed, but feel free to reopen if there are any new issues

Changed in mixxx:
status: New → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7640

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.