Default Action Trigger Templates Updates

[Josh Stompro]

Hello, I would like to make the following enhancements to the default action trigger event email templates.

1. Auto-Submitted header

In my experience staff don't really care that a customer is on vacation or out of the office when email notices get sent out. So I think the email template should include the header that disables Out of Office autoreplies for many system.

Auto-Submitted: auto-generated

http://tools.ietf.org/html/rfc3834

2. From

The following seems to be the suggested best practice for what the From field should be set to so that the various options for setting the From get used correctly.

From: [%- helpers.get_org_setting(target.home_ou.id, 'org.bounced_emails') || lib.email || params.sender_email || default_sender %]

The current default is

From: [%- params.sender_email || default_sender %]

Josh

[Josh Stompro (u-launchpad-stompro-org)]

Here is a branch that includes two commits with the two different changes mentioned.

Adding Auto-Submitted header and changing From line.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1391282_update_at_templates

Does anyone know if the environment needs to be changed for the from line to work correctly for each event definition?

Thanks
Josh

[Ben Shum (bshum)]

Oh I like the change for adding "Auto-Submitted: auto-generated"! That does sound like it could be a helpful gain.

As for the change to the From, I wonder if params.sender_email should come first in the series. That way, if someone does set a param for the individual event, it takes precedence over the other potential values. And I am not sure that "lib.email" will function as written, or if it ought to be circ_lib.email or something else. It may require adjustment to the environment, hmm..

[Galen Charlton (gmc)]

I've pushed the patch that adds the Auto-Submitted header to master for inclusion in 2.10. Thanks, Josh!

Given that there's pending discussion on the other part, as a bookkeeping matter, if you wish to pursue it further, please open a separate bug.