Traceback when copying or creating a theme with background image on Windows
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Medium
|
Tomas Groth |
Bug Description
Reproducable on Windows with the 2.1.1 beta
When copying a theme with background image I get this traceback:
Traceback (most recent call last):
File "C:\Users\
self.
File "C:\Users\
self.
File "C:\Users\
self.
File "C:\Users\
shutil.
File "c:\python33\
if _samefile(src, dst):
File "c:\python33\
return os.path.
File "c:\python33\
return _getfinalpathna
TypeError: must be str, not bytes
When createing a new theme with background image I get this traceback:
Traceback (most recent call last):
File "C:\Users\
self.
File "C:\Users\
self.
File "C:\Users\
shutil.
File "c:\python33\
if _samefile(src, dst):
File "c:\python33\
return os.path.
File "c:\python33\
return _getfinalpathna
TypeError: must be str, not bytes
Problem is in same method: _write_theme
Most likely shutil.copyfile cannot handle bytes input on windows. This is not an issue on linux.
Related branches
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 245 lines (+96/-19)8 files modifiedopenlp/core/ui/mainwindow.py (+8/-1)
openlp/core/ui/servicemanager.py (+3/-2)
openlp/core/ui/thememanager.py (+7/-3)
openlp/plugins/songs/lib/importers/worshipassistant.py (+32/-12)
tests/functional/openlp_core_common/test_settings.py (+12/-0)
tests/functional/openlp_plugins/songs/test_worshipassistantimport.py (+2/-0)
tests/resources/worshipassistantsongs/would_you_be_free.json (+1/-1)
tests/resources/worshipassistantsongs/would_you_be_free2.csv (+31/-0)
Changed in openlp: | |
assignee: | nobody → Tomas Groth (tomasgroth) |
status: | New → In Progress |
description: | updated |
Changed in openlp: | |
importance: | Undecided → Medium |
Changed in openlp: | |
milestone: | none → 2.1.2 |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |