"entire diff" subscription option can't always work
Bug #139071 reported by
Michael Hudson-Doyle
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
Currently, one of the diff size options is "send entire diff". This is, to some extent, a lie, as when diffs get really huge, mail servers are going to refuse to carry them (OOPS-619SMS1).
I guess a sane approach is to have a hard limit (defined how, I don't know). Measuring diff size as lines is of course not entirely correlated to diff size in bytes, which is probably what the mail server cares about...
Tangentially, I guess when diffs get too big, we can send codebrowse urls instead.
Related branches
lp:~thumper/launchpad/catch-email-send-failures
Merged
into
lp:launchpad
- Abel Deuring (community): Approve
- Diff: None lines
Changed in launchpad-bazaar: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
tags: | added: email |
Changed in launchpad-code: | |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 3.0 |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Perhaps the code that sends the diff by email can notice when the mail server says "the mail is too large for me!", and so send a URL instead.