Clean up db.instance_get_all_by_host() in NOVA api

Bug #1390483 reported by Daniele Casini
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
jichenjc

Bug Description

Currently, both db.* and objects are used. This patch replaces all db.* with objects (prefered solution).

Changed in nova:
assignee: nobody → Daniele Casini (daniele-casini)
summary: - Clean up db.instance_get_all_by_host() in NOVA api
+ Clean up db.* in NOVA api
description: updated
Changed in nova:
status: New → In Progress
summary: - Clean up db.* in NOVA api
+ Clean up db.instance_get_all_by_host() in NOVA api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133761

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/133761
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Removing "In Progress" status and assignee as change is abandoned.

Changed in nova:
status: In Progress → Confirmed
assignee: Daniele Casini (daniele-casini) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164132

Changed in nova:
assignee: nobody → jichenjc (jichenjc)
status: Confirmed → In Progress
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/164132
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5660899fc11055566f2dd495d35c016b4410ea10
Submitter: Jenkins
Branch: master

commit 5660899fc11055566f2dd495d35c016b4410ea10
Author: jichenjc <email address hidden>
Date: Tue Feb 24 18:52:22 2015 +0800

    Code clean up db.instance_get_all_by_host()

    Replaces db.instance_get_all_by_host()
    with objects.InstanceList.get_by_host()
    also, fixed several unit test cases fail by using
    mock to replace stub.

    Closes-Bug: #1390483

    Change-Id: I7da701f37d162f97b924cb8eede76de4f1c8bf7a

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.