Add contact from address - error somewhat misleading

[Jonathan Cave]

Version: 0.8.12.73

Steps to reproduce:
 * Have a contact on your phone with the phone number in local format (no country code)
 * Open telegram
 * Go to contacts list
 * Hit add contact button
 * Select "From Address Book"
 * Enter contacts selector and choose contact mentioned above and share it to telegram
 * Note the details are filled out in Add Contact form
 * Hit the tick button to accept

Actual result:
 - The dialog presents a red error message "Number is not a valid phone number"

Expected result:
 - This number *is* a valid phone number, however Telegram requires a country code to correctly identify a user

The app could may be hint that this is required rather than just displaying the current error message

[John McAleely (john.mcaleely)]

Should the address book supply a default country?

[John McAleely (john.mcaleely)]

(or should telegram have one)

[John McAleely (john.mcaleely)]

Given that this has been reported by the OEM QA team, please consider raising the priority of this bug.

[Noemí (noemi-gallego)]

Any updates with this bug?

[Michał Karnicki (karni)]

Hello Noemi, we were planning to fix it this week. I just did that, so we'll let it go through review. Should land today, and we'll include it in a week, unless for some reason we decide to cut an intermediate release.

[Jonathan Cave (jocave)]

Would be nice to detect automatically - but accept the improved error

[Noemí (noemi-gallego)]

I've tested with the new version (R19) and it shows the following message: please include the country code.
I supose this is something provisional until finding a solution right?

[Michał Karnicki (karni)]

Hi Noemi. We talked about this bug with another engineer, and the conclusion is:
- when adding a phone number from contacts, there's no way to determine which country is that contact from
- in case the country code is missing, we could pre-pend the logged-in user country code, so that means we assume the imported contacts are local to the user's country. I think it's a safe assumption.

Is the proposed solution what you'd expect? Please let me know here via comment. Thank you.