configuration parameters payload changed

Bug #1390317 reported by Craig Vyvial
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Critical
Craig Vyvial

Bug Description

The configuration parameters payload was originally just 'max' and 'min' for the range and was changed to 'max_value' and 'min_value' in the output.

Original output was what is in the validation rules file because it was just sent back through without a transformation.
{
    "name": "max_user_connections",
    "restart_required": false,
    "max": 100000,
    "min": 1,
    "type": "integer"
}

Now we are transforming the data from the database model and mis represented it in the view.
{
    "name": "max_user_connections",
    "min_size": "1",
    "datastore_version_id": "100000-000000-00000-00000000",
    "restart_required": false,
    "type": "integer",
    "max_size": "100000"
}

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133143

Changed in trove:
assignee: nobody → Craig Vyvial (cp16net)
status: New → In Progress
Revision history for this message
Sergey Gotliv (sgotliv) wrote :

Does this mis-representation breaks some existing functionality?

Revision history for this message
Amrith Kumar (amrith) wrote :

Should this be fixed on the stable branch as well?

Revision history for this message
Craig Vyvial (cp16net) wrote :

Sergey - Yes this payload change breaks the contract we had in the previous release for listing configuration parameters.

Amrith - I think so where "stable" is when you tag a bug with juno-rc-potential and it gets pushed into the juno release candidate.

Amrith Kumar (amrith)
no longer affects: trove (Ubuntu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/133143
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=2964620e4b2c3570e67ec7f55175327eb8752ce8
Submitter: Jenkins
Branch: master

commit 2964620e4b2c3570e67ec7f55175327eb8752ce8
Author: Craig Vyvial <email address hidden>
Date: Thu Nov 6 23:07:53 2014 -0600

    configuration parameters payload changed

    the configuration parameters payload was originally just 'max'
    and 'min' for the range and was changed to 'max_value' and
    'min_value' in the output. Reverting this back to the original
    v1 spec of 'max' and 'min'.

    Closes-Bug: #1390317
    Change-Id: I9628313e4154048a6aa9a089a6e3ec18f9af1d33

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/138577
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=881fd0ad39318626e8e3509143e1f88aa69e8a4e
Submitter: Jenkins
Branch: master

commit 881fd0ad39318626e8e3509143e1f88aa69e8a4e
Author: Craig Vyvial <email address hidden>
Date: Tue Dec 2 15:33:32 2014 -0600

    convert the max and min values to int instead of string

    Closes-Bug: #1390317
    Change-Id: I6e8517308e51b4a8a03ad4fc27166934a6104841

Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.