network admin state needs to be translatable

Bug #1390207 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Liyingjun

Bug Description

In several panels the network admin state is hardcoded to UP/DOWN. I know this was observed during code development and key points in the code are flagged. However, I could not find any existing bug to track this issue.

./openstack_dashboard/dashboards/admin/networks/ports/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/admin/networks/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/admin/networks/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/routers/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/firewalls/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/firewalls/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/vpn/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/vpn/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/vpn/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/vpn/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/networks/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/networks/ports/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/networks/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/workflows.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/forms.py: # TODO(amotoki): make UP/DOWN translatable
./openstack_dashboard/dashboards/project/loadbalancers/forms.py: # TODO(amotoki): make UP/DOWN translatable

Tags: i18n
Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
tags: added: i18n
Liyingjun (liyingjun)
Changed in horizon:
assignee: nobody → Liyingjun (liyingjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142012

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/142012
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=33092aec9b904adffefae571ae8fbec26c839239
Submitter: Jenkins
Branch: master

commit 33092aec9b904adffefae571ae8fbec26c839239
Author: liyingjun <email address hidden>
Date: Tue Dec 16 15:36:15 2014 +0800

    Make admin_state translatable

    In several panels the network admin state is hardcoded to UP/DOWN,
    this patch aims to make the admin_state translatable.

    Change-Id: Ia0e5ba02a4980c1db0d914e2689956feee5fb718
    Closes-bug: #1390207

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.