scss variables overriding mechanism

Bug #1390101 reported by Jiri Tomasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Jiri Tomasek

Bug Description

The horizon.scss now @imports _variables after importing bootstrap, which prevents us to override bootstrap variables there. (see how scss variables overriding work http://robots.thoughtbot.com/sass-default)

The fix should move _variables import before bootstrap import in horizon.scss and move all variables defined at the beginning of horizon.scss into _variables.scss.

Also, variables in _variables.scss shoudl be organized into 2 groups for clarity:
1. bootstrap overrides - variables that override bootstrap ones
2. custom horizon variables - variables used by horizon that are not defined by bootstrap

IMHO, all variables in _variables.scss should be marked as !default, so they can be overriden in horizon plugins to maintain Horizon's customization ability.

Tags: scss
Jiri Tomasek (jtomasek)
Changed in horizon:
assignee: nobody → Jiri Tomasek (jtomasek)
status: New → In Progress
Cindy Lu (clu-m)
Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133667

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/133667
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=75e01d70a8021f08deeddcaa0c61ae33993c89f1
Submitter: Jenkins
Branch: master

commit 75e01d70a8021f08deeddcaa0c61ae33993c89f1
Author: Jiri Tomasek <email address hidden>
Date: Mon Nov 10 11:08:15 2014 +0100

    Reorganize variables to enable overriding

    This patch enables scss variables to be overriden. It also cleans up unnecessary variables
    defined in _variables.scss because of previous wrong overriding.
    More details on

    Closes-Bug: 1390101
    Change-Id: I5078fe46ea6a992a096e2e23118a20cb199b7942

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.