[nailgun] Refactor attributes generation code

Bug #1390017 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Ihor Kalnytskyi

Bug Description

Now there are two methods for attributes traversal: traverse() and generate_editables(). They do almost the same things so let's DRY this.
Generator methods in AttributesGenerator() are to be reworked also.

Tests for generators are required also.

description: updated
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Ivan Kliuk (ivankliuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133960

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
milestone: 6.0 → 6.1
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: In Progress → Confirmed
Changed in fuel:
status: Confirmed → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: feature
Changed in fuel:
assignee: Ivan Kliuk (ivankliuk) → Igor Kalnitsky (ikalnitsky)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Ivan Kliuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/133960
Reason: The functionality has been implemented in patch-set #166226.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/166226
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=a80c2709015cc19eda96d5939f940e5ada674d20
Submitter: Jenkins
Branch: master

commit a80c2709015cc19eda96d5939f940e5ada674d20
Author: Igor Kalnitsky <email address hidden>
Date: Fri Mar 20 12:21:59 2015 +0200

    Use traverse for generating repo_setup

    Currently we're using Jinja2 template engine for generating repo_setup
    data in openstack.yaml. That's bad, because it requires to do so in
    fuel_upgrade script and doesn't support proper "OpenStack version"
    replacement.

    Since now, we're using our traversal mechanism for generating cluster
    attributes.

    Closes-Bug: #1434494
    Closes-Bug: #1390017

    Change-Id: Ia03308514e9e6b9b6ed8d14d0a156e14314b21e2

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.