Fast Panorama preview doesn't honour 'overview' setting

[tduell]

Build of hugin_executor branch (6766:e2bc1c33f588) on Fedora 20 x86_64.
I notice that when I open the Fast Panorama preview window I sometimes get the 'overview' pane, even though I haven't previously used this view.
To remove the 'overview' pane I have to select view -> overview (which isn't ticked even though the 'overview' pane is displayed), then repeat, this time deselecting it, and this closes the overview pane.
This behaviour, which appears to be random, has been around for a while, and I should I have reported it earlier.

Cheers,
Terry

[tmodes (tmodes)]

Hi Terry,

I can't reproduce the issue on Windows. So we need to trackle down the issue.

When the fast preview window is destroyed, the settings are stored (see function GLPreviewFrame::~GLPreviewFrame() in src/hugin1/hugin/GLPreviewFrame.cpp) in the preferences:

[GLPreviewFrame]
width=1278 -> width of window
height=515 -> height of window
positionX=0 -> x position
positionY=0 -> y position
maximized=0 -> window maximized or not
isShown=0 -> should fast preview window automatically opened at Hugin start
OpenGLLayout=layout2|name=preview;caption=Vorschau;state=896;dir=5;layer=0;row=0;pos=0;prop=100000;bestw=300;besth=200;minw=300;minh=200;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=overview;caption=Übersicht;state=16779260;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=300;besth=200;minw=300;minh=200;maxw=-1;maxh=-1;floatx=500;floaty=500;floatw=100;floath=100|dock_size(5,0,0)=302|dock_size(4,0,0)=302| -> layout of all sub windows (size, position, floated/docked...)
overview_hidden=1 -> overview shown or hidden
showPreviewGrid=0 > show or hide grid

When the fast preview window is shown, the settings are read in GLPreviewFrame::GLPreviewFrame (around line 756) and in void GLPreviewFrame::LoadOpenGLLayout().

The main items should be OpenGLLayout and overview_hidden.
Could you try to have a look at these 2 item?
Especially compare these two when all is okay and when the overview is wrongly shown (you have to check the preferences file when the issue happens, don't close Hugin before).

PS: The OpenGLLayout string is directly delivered from wxWidgets and send back to wxWidgets. Hugin does not do any processing with this string. So it may also be an issue in wxWidgets.

TIA

[tduell (tduell-iinet)]

Hello Thomas,
Thanks for the detailed advice on this.
Now that I'm looking for it I have also been unable to reproduce the problem.
It has been random, or appeared to be so.
I will just have to keep it in the back of mind and check the preferences file when it happens again.

Cheers,
Terry

[tduell (tduell-iinet)]

OK, caught it.
Attached is screenshot, which shows overview pane but nothing in it, and view menu showing overview unticked, also my .hugin at the time.
Sing out if you need anything else to track this bugger down.

Cheers,
Terry

[tmodes (tmodes)]

The settings seems to be correctly stored, but I don't know why they are not restored correctly.

[tduell (tduell-iinet)]

It is an intermittent problem here, and appears to be random.
Maybe it is a local problem, something related to my particular system.
Thanks for your help.

Cheers,
Terry

[tmodes (tmodes)]

I still understand why it works sometime and sometimes not.

I committed in changeset 0b8eec60a38f a workaround. I explicitly hide the overview window when the last usage was so. Normally this should be handled by LoadPerspective.
So trying if this solves your problem.

[tduell (tduell-iinet)]

Hello Thomas,
I have built the latest source, and will see how it goes.

Cheers,
Terry