Fix neutron agents start in OCF

Bug #1389299 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Bogdan Dobrelya

Bug Description

neutron agents start command in OCF contains wrong redirection:
    su ${OCF_RESKEY_user} -s /bin/sh -c "${OCF_RESKEY_binary} --config-file=$OCF_RESKEY_config \
        --config-file=$OCF_RESKEY_plugin_config --log-file=$OCF_RESKEY_log_file $OCF_RESKEY_additional_parameters "' 2>&1 &'

And this one prevents start action to be completed detached
The fix should be:
        --config-file=$OCF_RESKEY_plugin_config --log-file=$OCF_RESKEY_log_file $OCF_RESKEY_additional_parameters \
         >> /dev/null"' 2>&1 & echo $!' > $OCF_RESKEY_pid

This one will redirect output to /dev/null due to we use --log-file (https://bugs.launchpad.net/fuel/+bug/1371629) AND fix pid-file creation as well

How to reproduce:
* Deploy Ha neutron environment from latest 6.0 ISO
* Login to primary controller node and issue:
pcs resource disable clone_p_neutron-openvswitch-agent || pcs resource disable p_neutron-plugin-openvswitch-agent
OCF_ROOT=/usr/lib/ocf OCF_RESKEY_plugin_config=/etc/neutron/plugin.ini /usr/lib/ocf/resource.d/mirantis/neutron-agent-ovs stop;
OCF_ROOT=/usr/lib/ocf OCF_RESKEY_plugin_config=/etc/neutron/plugin.ini /usr/lib/ocf/resource.d/mirantis/neutron-agent-ovs start

Expected: it should run neutron agent ovs process detached and put its pid to $OCF_RESKEY_pid destination

Actual: it will run in foreground and will not create a pid file.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132691

Changed in fuel:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
Changed in fuel:
milestone: none → 6.0
importance: Undecided → Critical
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/132691
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=5ab922e5ac9680fd99c16fe552096efcc9388ed2
Submitter: Jenkins
Branch: master

commit 5ab922e5ac9680fd99c16fe552096efcc9388ed2
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Nov 4 17:19:07 2014 +0100

    Fix neutron-agents start commands in OCF

    W/o this fix, n-agents can not detach start command
    and create a pidfile
    The solution is to fix start command as appropriate

    Closes-bug: #1389299

    Change-Id: I46e1cf286622db0d64e9f17f72ed632e43906e05
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
description: updated
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #49

"build_id": "2014-12-09_22-41-06", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "49", "auth_required": true, "api": "1.0", "nailgun_sha": "22bd43b89a17843f9199f92d61fc86cb0f8772f1", "production": "docker", "fuelmain_sha": "3aab16667f47dd8384904e27f70f7a87ba15f4ee", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-09_22-41-06", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "49", "api": "1.0", "nailgun_sha": "22bd43b89a17843f9199f92d61fc86cb0f8772f1", "production": "docker", "fuelmain_sha": "3aab16667f47dd8384904e27f70f7a87ba15f4ee", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "2c99931072d951301d395ebd5bf45c8d401301bb"}}}, "fuellib_sha": "2c99931072d951301d395ebd5bf45c8d401301bb"

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.