Upgrade fail because puppet modules were not found

[Sebastian Kalinowski]

When trying to run upgrade script, it fails:

[root@fuel tmp]# ./upgrade.sh --no-rollback --password admin
2014-11-04 13:17:14 ERROR 32482 (cli) list index out of range
Traceback (most recent call last):
  File "/var/tmp/upgrade/site-packages/fuel_upgrade/cli.py", line 175, in main
    run_upgrade(parse_args(sys.argv[1:]))
  File "/var/tmp/upgrade/site-packages/fuel_upgrade/cli.py", line 148, in run_upgrade
    config = build_config(args.src, args.password)
  File "/var/tmp/upgrade/site-packages/fuel_upgrade/config.py", line 88, in build_config
    return Config(config(update_path, admin_password))
  File "/var/tmp/upgrade/site-packages/fuel_upgrade/config.py", line 638, in config
    host_system = get_host_system(update_path, new_version)
  File "/var/tmp/upgrade/site-packages/fuel_upgrade/config.py", line 199, in get_host_system
    openstack_version = sorted(openstack_versions, reverse=True)[0]
IndexError: list index out of range
==================================================
Upgrade failed

There are missing puppet modules for 6.0:
[root@fuel tmp]# ls upgrade/puppet/
2014.1.1-5.0.2 manifests modules

Looks like it happened after merging https://review.openstack.org/#/c/124734/

Upgrade package:
http://jenkins-product.srt.mirantis.net:8080/view/6.0/job/6.0.iso/70/

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.0"
  api: "1.0"
  build_number: "70"
  build_id: "2014-11-03_21-27-07"
  astute_sha: "c72dac7b31646fbedbfc56a2a87676c6d5713fcf"
  fuellib_sha: "a2e7e222c93aa17da8ddd3b0c2b49eacd0a81580"
  ostf_sha: "9c6fadca272427bb933bc459e14bb1bad7f614aa"
  nailgun_sha: "35946b1f225c984f11915ba8e985584160f0b129"
  fuelmain_sha: "9012d6252d23f56a244142e5341bdcb2fc1ce5ef"

Also reproduced for upgrade tarballs: #73, #69

Tarball without this issue: #66

[Ihor Kalnytskyi (ikalnytskyi)]

Current 6.0.iso job does't use new make system approach. We need to use artifacts from an upgrade swarm.

[Sergey Kulanov (skulanov)]

Could you please check the latest upgrade tarball from the below job #5?
http://jenkins-product.srt.mirantis.net:8080/view/upgrade/job/6.0_upgrade/5/

[Sebastian Kalinowski (prmtl)]

http://jenkins-product.srt.mirantis.net:8080/view/upgrade/job/6.0_upgrade/5/ - tested, worked OK.

Only problem was with the need of unpacking it two times (archive inside archive).