Wrong IPs allocation when using multiple node groups

[Aleksey Kasatkin]

Here:

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#L136

This tries to get admin IPs for all nodes (which can be from different groups) from one admin IP range.
It will be a problem in case of using multiple node groups only.

[Aleksey Kasatkin (alekseyk-ru)]

Same for other IPs:

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#L228

[Egor Kotko (ykotko)]

Got the same on Jenkins job.
{"build_id": "2014-11-04_03-44-56", "ostf_sha": "9c6fadca272427bb933bc459e14bb1bad7f614aa", "build_number": "73", "auth_required": true, "api": "1.0", "nailgun_sha": "35946b1f225c984f11915ba8e985584160f0b129", "production": "docker", "fuelmain_sha": "f395aeaed369d9c55588d37aa21e180f3d852f65", "astute_sha": "c72dac7b31646fbedbfc56a2a87676c6d5713fcf", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-11-04_03-44-56", "ostf_sha": "9c6fadca272427bb933bc459e14bb1bad7f614aa", "build_number": "73", "api": "1.0", "nailgun_sha": "35946b1f225c984f11915ba8e985584160f0b129", "production": "docker", "fuelmain_sha": "f395aeaed369d9c55588d37aa21e180f3d852f65", "astute_sha": "c72dac7b31646fbedbfc56a2a87676c6d5713fcf", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "2a314f9d14ea045b4b917d01d6c8f9a732ca1d7f"}}}, "fuellib_sha": "2a314f9d14ea045b4b917d01d6c8f9a732ca1d7f"}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/133559

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/133559
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=5e78bd677b8c46bd4251dad7d3a470e02df433fe
Submitter: Jenkins
Branch: master

commit 5e78bd677b8c46bd4251dad7d3a470e02df433fe
Author: Ryan Moe <email address hidden>
Date: Mon Nov 10 21:48:50 2014 +0300

    Assign IPs from networks in each node's group

    Previously nodes were assigned incorrect IPs if nodes from
    more than one node group were being assigned IPs. All nodes would
    be assigned IPs from the last network group processed irrespective
    of the node's actual group.

    Change-Id: I3d170d23bf3402d88161adb264240b85ebc7bdd4
    Closes-bug: #1389160