OS::Heat::AutoScalingGroup doesn't validate the resource type before creation

Bug #1389104 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
huangtianhua

Bug Description

AutoScalingGroup doesn't validate before creation:

heat_template_version: 2013-05-23

resources:
  config:
    type: OS::Heat::AutoScalingGroup
    properties:
      resource:
        type: My::ConfiguredServer
      desired_capacity: 2
      max_size: 4
      min_size: 1

This ends up CREATE_FAILED if you forget to pass the environment mapping the My::ConfiguredServer type.
See https://bugs.launchpad.net/heat/+bug/1388140

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132968

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by huangtianhua (<email address hidden>) on branch: master
Review: https://review.openstack.org/132968
Reason: abandon this change, fix the bug in patch:
https://review.openstack.org/#/c/132625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/132625
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c31c34f8dfd0919bf46a975701c139073115debc
Submitter: Jenkins
Branch: master

commit c31c34f8dfd0919bf46a975701c139073115debc
Author: huangtianhua <email address hidden>
Date: Tue Nov 4 14:46:39 2014 +0800

    Do static template validation for nested stacks

    Currently we don't fail fast, even if there is an error
    in the nested template which should fail validation.
    This change to recurse and do static template validation
    for nested stack resources.

    Change-Id: I572ded640582419e0888e4b9f8eed3a3432d6121
    Closes-Bug: #1388140
    Closes-Bug: #1389104

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.