Training ICR includes unverified images

Bug #1388658 reported by Adam Zammit
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
queXF
Fix Released
High
Adam Zammit

Bug Description

The ICR doesn't screen out characters entered where vid == 0 (auto verified)

Related branches

Revision history for this message
Adam Zammit (adamzammit) wrote :

In admin/icrtrain.php replace:

  $sql = "SELECT b.bid as bid, b.tlx as tlx, b.tly as tly, b.brx as brx, b.bry as bry, c.val as val, b.pid as pid,b.bgid as bgid, f.fid, c.vid as vid
    FROM formboxverifychar as c
    JOIN boxes as b ON (b.bid = c.bid)
    JOIN formpages as f ON (f.fid = c.fid AND f.pid = b.pid)
    JOIN boxgroupstype as bg ON (bg.bgid = b.bgid and (bg.btid = 3 or bg.btid = 4))
    JOIN forms AS fm ON fm.fid = f.fid
    LEFT JOIN ocrtrain as oc ON (oc.fid = f.fid AND oc.vid = c.vid AND oc.bid = b.bid)
    WHERE c.val = '$char'
    AND fm.qid = '$qid'
    $verifiers
    AND oc.ocrtid IS NULL
    ORDER BY fm.fid DESC
    LIMIT " . ICR_TRAIN_LIMIT;

with:

SELECT b.bid as bid, b.tlx as tlx, b.tly as tly, b.brx as brx, b.bry as bry, c.val as val, b.pid as pid,b.bgid as bgid, f.fid, c.vid as vid
    FROM formboxverifychar as c
    JOIN boxes as b ON (b.bid = c.bid)
    JOIN formpages as f ON (f.fid = c.fid AND f.pid = b.pid)
    JOIN boxgroupstype as bg ON (bg.bgid = b.bgid and (bg.btid = 3 or bg.btid = 4))
    JOIN forms AS fm ON fm.fid = f.fid
    LEFT JOIN ocrtrain as oc ON (oc.fid = f.fid AND oc.vid = c.vid AND oc.bid = b.bid)
    WHERE c.val = '$char'
    AND c.vid != 0
    AND fm.qid = '$qid'
    $verifiers
    AND oc.ocrtid IS NULL
    ORDER BY fm.fid DESC
    LIMIT " . ICR_TRAIN_LIMIT;

(i.e. add the line: AND c.vid != 0 )

Adam Zammit (adamzammit)
Changed in quexf:
status: New → Fix Committed
Adam Zammit (adamzammit)
Changed in quexf:
milestone: none → 1.17.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.