Desktop file shouldn't have a hardcoded icon

[Yuri Pieters]

The Variety launcher, extras-variety.desktop, uses a hardcoded icon path.
It should really use the freedesktop standard (http://www.freedesktop.org/wiki/Howto_desktop_files/).
Hardcoding means a user needs root privaleges to change the icon, and it's not themeable.

[Peter Levi (peterlevi)]

There is a legacy reason for this. Variety was initially in Ubuntu Software Center, where the requirement was that all application files, except for the desktop file should be within the app directory in /opt/extras.ubuntu.com/variety/. This included icons.
Variety still uses the same build process and same conventions and installs in opt.

I am in the process of changing this, and Variety will sometime soon be packaged in the ordinary Debian way. When this happens I will also package the icons the usual way and name them simply "variety" and "variety-indicator".

I'm not still sure what I should do with the indicator icon customization options in Preferences -> Customize. Currently one can change the indicator icon from the program. Once the icons are themable, this might be superfluous, but on the other hand, most themes won't have dedicated icons for Variety's indicator so I guess it makes sense to leave the "light" and "dark" options. So we might end up with "variety-indicator-light" and "variety-indicator-dark".

[Bilal Elmoussaoui (bilal-elmoussaoui)]

Numix icons is supporting variety and variety indicator ! all we need is to see this update asap :D
thanks

[Bilal Elmoussaoui (bilal-elmoussaoui)]

Well, it's not the case i'm using the latest version of variety using your ppa and the icon is still hardcoded. Maybe you didn't release this version yet?

[Peter Levi (peterlevi)]

It's committed, not yet released to the official PPA. You'll get it if you use the daily PPA which is build daily from trunk: ppa:variety/daily.

[Bilal Elmoussaoui (bilal-elmoussaoui)]

I see, thank you very much for you hard work!