System.InvalidOperationException at ORTS.SoundProcess.Sound (X2616)

Bug #1388342 reported by disc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
High
James Ross

Bug Description

with commit 2616 this exeption crashes the game randomly:

Error: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
   at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
   at ORTS.SoundProcess.Sound() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\SoundProcess.cs:line 131
   at ORTS.SoundProcess.DoSound() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\SoundProcess.cs:line 91
   at ORTS.SoundProcess.SoundThread() in c:\Users\James\Documents\Coding\Jenkins\jobs\Open Rails\workspace\Source\RunActivity\Processes\SoundProcess.cs:line 75
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Tags: crash sounds
disc (disc86543)
summary: - Error: System.InvalidOperationException: Collection was modified;
- enumeration operation may not execute. at
- System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource
- resource) at ORTS.SoundProcess.Sound() in
- c:\Users\James\Documents\Coding\Jenkins\jobs\Open
- Rails\workspace\Source\RunActivity\Processes\SoundProcess.cs:line 131
- at ORTS.SoundProcess.DoSound() in
- c:\Users\James\Documents\Coding\Jenkins\jobs\Open
- Rails\workspace\Source\RunActivity\Processes\SoundProcess.cs:line 91
- at ORTS.SoundProcess.SoundThread() in
- c:\Users\James\Documents\Coding\Jenkins\jobs\Open
- Rails\workspace\Source\RunActivity\Processes\SoundProcess.cs:line 75
- at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at
- System.Threading.ExecutionContext.Run(ExecutionContext executionContext,
- ContextCallback callback, Object state) at
- System.Threading.ThreadHelper.ThreadStart()
+ Sound process exeption form 2616 commit.
summary: - Sound process exeption form 2616 commit.
+ Sound process exception since commit 2616
Revision history for this message
James Ross (twpol) wrote :

For reference, X2616 just removed the "eat all errors and ignore them" code so this has likely been going on for ages. I'm attempting to fix it now.

Changed in or:
status: New → Triaged
importance: Undecided → High
assignee: nobody → James Ross (twpol)
milestone: none → 1.0
summary: - Sound process exception since commit 2616
+ System.InvalidOperationException at ORTS.SoundProcess.Sound (X2616)
Changed in or:
status: Triaged → In Progress
Revision history for this message
James Ross (twpol) wrote :

Fixed in X2617.

Changed in or:
status: In Progress → Fix Committed
Changed in or:
status: Fix Committed → In Progress
status: In Progress → Fix Committed
James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.