Deletes desktop on Windows with Winapp2.ini

Bug #1388322 reported by Simes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BleachBit
Fix Released
Medium
Unassigned

Bug Description

Hi BB, the very first entry on the log when I run BB is: Delete 0 C:\Users\<username>\Desktop
Seems an odd deletion as has a run-on effect of damaging the user profile (as windows creates new blank desktop and archives old one in users directory - but with same directory name/path in windows).
This has only started happening since 1.4 (am using portable) on Vista 64.
Should note that I do have the winapp2.ini entries loaded.
I can whitelist the directory, which seems to solve the issue - but just thought I'd report the issue incase not just on my machine.

Revision history for this message
Andrew Ziem (ahziem1) wrote :

You are right that this looks wrong

In BleachBit itself there are not any rules that match %UserProfile%\Desktop, but there are some in Winapp2.ini that match entries under the desktop. Are you using any of these?

[BumpTop StickyNotes*]
[K-Lite Codec Pack*]
[MyCraft*]
[Norton Power Eraser*]
[OpenOffice.org Setup Files*]
[Rkill*]

Revision history for this message
Simes (soflond2014) wrote :

Thanks. I first downloaded a new Winapp2.ini and because have openoffice installed, then deleted the lines:

[OpenOffice.org Setup Files*]
LangSecRef=3021
Detect1=HKLM\Software\OpenOffice.org
Detect2=HKLM\Software\Wow6432Node\OpenOffice.org
Detect3=HKLM\Software\OpenOffice
Detect4=HKLM\Software\Wow6432Node\OpenOffice
FileKey1=%UserProfile%\Desktop|OpenOffice.org * Installation Files|REMOVESELF

but (without whitelisting) still get the desktop deleted - as per line in log:
Mark for deletion 0 C:\Users\simon\Desktop

Revision history for this message
Andrew Ziem (ahziem1) wrote :

If you modify Winapp2.ini and have automatic updates enabled, the changes will get overwritten the next time you start BleachBIt.

Would you consider running a preview either one section or option at a time? A quick way to preview one option (without checking or unchecking anything) is to right click on the option, and in the popup menu, choose preview.

Thanks for your help. Once I can reproduce the problem, I'd like to fix it soon.

Changed in bleachbit:
status: New → Confirmed
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Actually, it is this OpenOffice.org setup files entry.

Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: none → 1.8
Revision history for this message
Andrew Ziem (ahziem1) wrote :

I tested OpenOffice.org Setup Files with BleachBit 1.5.2 and Windows XP SP3. The desktop folder shows up in the preview, but it should not.

The good news is that on my system deleting the desktop folder fails because the desktop folder is not empty, and there is no instruction to delete any contents other than the OpenOffice.org setup folders.

On your system did it actually delete the desktop folder?

H:\bleachbit>bleachbit.py --clean winapp2_applications.openoffice_org_setup_files
debug: clean_operation('winapp2_applications'), options = '['openoffice_org_setup_files']'
info: directory 'C:\Documents and Settings\a\Desktop' is not empty
Delete 0 C:\Documents and Settings\a\Desktop
Disk space recovered: 0
Files deleted: 1

Changed in bleachbit:
importance: Undecided → Low
Revision history for this message
Simes (soflond2014) wrote : Re: [Bug 1388322] Re: BB 1.4 deletes desktop on Vista 64

Hi Andrew, I should clarify my initial report: the desktop (folder) and
it's contents don't so much get deleted, but rather archived under the
user folder structure. Clicking anything on the desktop (which still
shows) reports that it is not available anymore. On logging off and then
logging back on, a new (clean) desktop folder is created by windows. I
don't get the same happening on an XP machine with Open Office on it,
only the Vista machine.

I wasn't quite sure if you were meaning you'd located something you
think might have been causing it, and that you would like me to try a
new version - or whether you would still like me to do the first preview
test you detailed.

thanks,
Simon

On 02/11/2014 20:27, Andrew Ziem wrote:
> I tested OpenOffice.org Setup Files with BleachBit 1.5.2 and Windows XP
> SP3. The desktop folder shows up in the preview, but it should not.
>
> The good news is that on my system deleting the desktop folder fails
> because the desktop folder is not empty, and there is no instruction to
> delete any contents other than the OpenOffice.org setup folders.
>
> On your system did it actually delete the desktop folder?
>
> H:\bleachbit>bleachbit.py --clean winapp2_applications.openoffice_org_setup_files
> debug: clean_operation('winapp2_applications'), options = '['openoffice_org_setup_files']'
> info: directory 'C:\Documents and Settings\a\Desktop' is not empty
> Delete 0 C:\Documents and Settings\a\Desktop
> Disk space recovered: 0
> Files deleted: 1
>
>
> ** Changed in: bleachbit
> Importance: Undecided => Low
>

Revision history for this message
Simes (soflond2014) wrote :

Further clarification: I should explain that when I wrote 'deleted the
desktop folder', I am referring to specific user files/directories on
the desktop, not generic items like my computer, etc. As previous, these
user specific items are archived under the user profile and a new clean
desktop folder created/mounted on next logon. After BB has been run, and
the specific desktop items 'removed' (and before user has logged
off/logged on again)they still show on the desktop, but when they are
clicked on, windows reports 'item no longer available' (as it has been
moved to new location).

Revision history for this message
Andrew Ziem (ahziem1) wrote : Re: BB 1.4 deletes desktop on Vista 64

On Windows 7 I notice that BleachBit will "mark for deletion" the desktop, so that means on reboot the desktop is deleted.

As a temporary workaround, I modified Winapp2.ini (git f2750be).

Thank you for reporting this bug.

Changed in bleachbit:
status: Confirmed → Triaged
importance: Low → Medium
summary: - BB 1.4 deletes desktop on Vista 64
+ Deletes desktop on Windows with Winapp2.ini
tags: added: winapp2.ini
Revision history for this message
Simes (soflond2014) wrote : Re: [Bug 1388322] Re: BB 1.4 deletes desktop on Vista 64

Thankyou Andrew - and as well, for such a great app.

Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: 1.8 → 1.10
Andrew Ziem (ahziem1)
tags: added: windows
Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: 1.10 → 1.12
Revision history for this message
Andrew Ziem (ahziem1) wrote :

I did some more checking, and this seems to be a bug in the Winapp2.ini data file and not in BleachBit, so I emailed Rob.

Andrew Ziem (ahziem1)
Changed in bleachbit:
status: Triaged → In Progress
Revision history for this message
Andrew Ziem (ahziem1) wrote :

No response from Rob, and oddly there are no updates to Winapp2.ini since March

Changed in bleachbit:
milestone: 1.12 → 1.14
Revision history for this message
Andrew Ziem (ahziem1) wrote :

I patched downstream Winapp2.ini and emailed ROCKNROLLKID about fixing it upstream

Revision history for this message
ROCKNROLLKID (slinger1410-deactivatedaccount) wrote :

The only thing I could think of what is causing this is the wildcard on the FileKey, but this can't be removed without effecting BleachBit's cleaning ability towards OpenOffice. This is because each time OpenOffice updates, the folder name, by default, changes to a new name and if you are on a different language other then English, it will also change the name of that folder. The best solution you can do for yourself is rewrite that cleaner to a static key (without the wildcard) for yourself so this error doesn't produce anymore. The best way to do this is to simply the name of the folder to a short name like "OpenOffice 4.1.2" or whatever and change the FileKey to the exact path directory. This way it won't detect the whole desktop anymore.

I am not seeing this issue in CCleaner or System Ninja and since the bug seems to be harmless, I think just applying a silent error message in BleachBit is the best solution here.

Revision history for this message
ROCKNROLLKID (slinger1410-deactivatedaccount) wrote :

this should be fixed in the last commit I made in GitHub. Can you please download the latest copy from here: https://github.com/MoscaDotTo/Winapp2

Let me know if this fixed it. Please make sure to use the non-CCleaner version of Winapp2 for BleachBit.

Andrew Ziem (ahziem1)
Changed in bleachbit:
status: In Progress → Fix Committed
Andrew Ziem (ahziem1)
Changed in bleachbit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.