VMware: Improve logging on failure due to invalid guestId

[OpenStack Infra]

https://review.openstack.org/114529
commit a98dcc636104283d3089f02e5b0fc2b045046ce7
Author: Matthew Booth <email address hidden>
Date: Fri Aug 15 14:11:13 2014 +0100

    VMware: Improve logging on failure due to invalid guestId

    If a glance image has a vmware_ostype property which doesn't
    correspond to a valid VMware guestId, VM creation will fail with the
    unhelpfully generic error message:

    A specified parameter was not correct.

    This change improves this situation slightly by logging a warning if
    VM creation fails and guestId is not a recognised value. We limit
    ourselves to logging a warning because we don't want to tightly couple
    ourselves to the vSphere behaviour. We can't guarantee that this is
    the reason the RPC call failed, or that it is the only reason the RPC
    call failed.

    DocImpact

    This change doesn't impact the behaviour of the VMware driver except
    that it will emit an additional warning message to the logs under the
    circumstances described. However, given the potential for
    user misconfiguration, we should describe this pitfall in the docs.

    Closes-Bug: #1357263
    Change-Id: I10e0982c6c450facdeea41c7f1d266e20a924d08

[Lana (loquacity)]

Add an admonition here: http://docs.openstack.org/newton/config-reference/compute/hypervisor-vmware.html#supported-image-types

Reading something like: "If a glance image has a vmware_ostype property which doesn't correspond to a valid VMware guestId, VM creation will fail, and a warning will be logged."

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408383

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408383
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=c4e22ec93c696113cd358b15b0f28225e6305b18
Submitter: Jenkins
Branch: master

commit c4e22ec93c696113cd358b15b0f28225e6305b18
Author: Lana Brindley <email address hidden>
Date: Thu Dec 8 12:39:21 2016 +1000

    Adding note about VM creation failure

    As per bug, if an invalid guestID is specified in a vmware_ostype
    property, VM creation will fail.

    Change-Id: I8a1e29071fc882d1bd5dd59a0477cc0df073fc7b
    Closes-Bug: #1387862

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.