TGT and ISER Fail When volume name Is Not In provider_location

[Mike Perez]

For ISER and Tgtadmin in cinder.volume.iscsi when the name changes from what's in the provider_location, we call _fix_id_migration(). However this requires 4 args and we're currently only passing 3 in it's only use.

https://github.com/openstack/cinder/blob/master/cinder/volume/iscsi.py#L112

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/131582

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/131582
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f61b3bd0beb52808383358de15df39dcaf2aa60c
Submitter: Jenkins
Branch: master

commit f61b3bd0beb52808383358de15df39dcaf2aa60c
Author: Mike Perez <email address hidden>
Date: Tue Oct 28 14:48:50 2014 -0700

    Fix wrong arg number for _fix_id_migration issue

    If the provider_location doesn't contain the name of the volume, TGT and
    ISER will fail on doing a id migration, due to wrong number of
    arguments.

    Change-Id: I420ceaf14edfb6a0e3b8fd1f50070dc70b6f16bd
    Closes-Bug: #1386902

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/131843

[Dave Walker (davewalker)]

@Mike, can you help solve a question on the stable/juno proposed backport. John Griffith has raised that he can't see when this code path is being called.

Thanks

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Perez (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/131843