Unhandled exception in get_replication_snapshot

[Peter Stachowski]

Unexpected errors that occur while generating the replication snapshot (for example, TemplatesNotFound) are not logged. This can lead to accidental hiding of the root cause of a problem.

The error should be written to the log and then re-thrown as a TroveError.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/131565

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/131565
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=18001e00055a8a4b282c1ced892989152409319b
Submitter: Jenkins
Branch: master

commit 18001e00055a8a4b282c1ced892989152409319b
Author: Peter Stachowski <email address hidden>
Date: Tue Oct 28 01:47:11 2014 -0400

    Fix exception handling in get_replication_snapshot

    Unexpected errors that occur while generating the replication snapshot
    (for example, TemplatesNotFound) are not logged. This can lead to
    accidental hiding of the root cause of a problem.

    All exceptions are now written to the log and then re-thrown.

    Change-Id: I48de0e099494b204a8b109caedb4b86a616024f1
    Closes-Bug: #1386875