A single space verbose_name of data_processing/clusters/tabs InstancesTable is difficult to translate

Bug #1386614 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Martin Hickey

Bug Description

(From Transifex issue)

The verbose_name of InstancesTable is just a single space.
It is a string with a single SPACE and it is used to just ignore a name in the code.
It is difficult for translators to understand.

This string has no meaning for translations, so I would suggest NOT
to mark translatable with a meaningful inline comment.
(Otherwise, we should add a reasonable translators note and contextual marker to the string.)

openstack_dashboard/dashboards/project/data_processing/clusters/tabs.py

class InstancesTable(tables.DataTable):
    name = tables.Column("name",
                         link=("horizon:project:instances:detail"),
                         verbose_name=_("Name"))

    internal_ip = tables.Column("internal_ip",
                                verbose_name=_("Internal IP"))

    management_ip = tables.Column("management_ip",
                                  verbose_name=_("Management IP"))

    class Meta:
        name = "cluster_instances"
        # Just ignoring the name.
        verbose_name = _(" ")

Chris Grivas (chgri)
description: updated
Changed in horizon:
assignee: nobody → Martin Hickey (martin-hickey)
Revision history for this message
GB21 (geetika791) wrote :

Mr Martin Hickey,are you working on this already.Because I would like to work on it.
Thanks

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/157155

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/157155
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=61a69b585bd1a956511dd6f497a9dc29d29c79ed
Submitter: Jenkins
Branch: master

commit 61a69b585bd1a956511dd6f497a9dc29d29c79ed
Author: Martin Hickey <email address hidden>
Date: Wed Feb 18 21:25:14 2015 +0000

    Add string for verbose name

    The verbose_name of InstancesTable is just a single space.
    This string has no meaning for translations.
    Make translatable by adding a suitable string Cluster Instances.

    Change-Id: Ic199366ab5e2ab128b75a642ee440485fbbd9df4
    Closes-Bug: #1386614

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.