Ironic python agent Conf should modify

Bug #1386486 reported by jiangfei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Jim Rollenhagen

Bug Description

ironic_python_agent.cmd.agent:run start. the CONF's api_url, is not find, also advertise_port ,listen_host etc.

I think the best CONF unity with other components openstack, so the CONF should be modify

jiangfei (jiangfei0622)
Changed in ironic:
assignee: nobody → jiangfei (jiangfei0622)
jiangfei (jiangfei0622)
summary: - Ironic python agent start failed
+ Ironic python agent Conf should modify
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/131632

Changed in ironic:
status: New → In Progress
Revision history for this message
Jay Faulkner (jason-oldos) wrote :

I believe this bug is saying that our config variables are currently delineated with a - (i.e. api-url) whereas most Openstack projects use _ (i.e. api_url).

I'm not sure this should actually count as a bug, but if we do fix it we must ensure to keep backwards compatibility with existing agents.

Changed in ironic:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137550

Changed in ironic:
assignee: jiangfei (jiangfei0622) → Jim Rollenhagen (jim-rollenhagen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/131632
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=597d6245b159ecd46e27e60c5df6469db48b9700
Submitter: Jenkins
Branch: master

commit 597d6245b159ecd46e27e60c5df6469db48b9700
Author: jiangfei <email address hidden>
Date: Wed Oct 29 12:28:59 2014 +0800

    Use _ instead of - for config options

    Config options containing "-" don't work when reading
    configuration from a file; change these to "_". Leave
    the old options for backwards compatibility.

    Closes-Bug: #1386486

    Change-Id: Ie10a548191effa2a505309d9d4ee32003f9676a2

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by jiangfei (<email address hidden>) on branch: master
Review: https://review.openstack.org/137550

Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.