Using the CLI with insufficient privileges results in incorrect error

[aeva black]

Demonstrating with current client:

deva@devstack:/opt/stack/python-ironicclient$ export OS_USERNAME=admin
deva@devstack:/opt/stack/python-ironicclient$ ironic node-list
+--------------------------------------+---------------+-------------+--------------------+-------------+
| UUID | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+---------------+-------------+--------------------+-------------+
| 669158c7-02d2-4234-803b-5ade8e8b53c8 | None | power off | None | False |
| 7ed0eccc-86bd-44c3-8457-790a848987a6 | None | power off | None | False |
| 172958d9-4e65-480f-af9f-ad67b8dccd0c | None | power off | None | False |
+--------------------------------------+---------------+-------------+--------------------+-------------+

deva@devstack:/opt/stack/python-ironicclient$ export OS_USERNAME=demo
deva@devstack:/opt/stack/python-ironicclient$ ironic node-list
'unicode' object has no attribute 'get'

This was introduced in commit e3d356476be376ebd3dfb3e84f379e113e5efac7

[aeva black (tenbrae)]

This error appears to be raised from this line:

http://git.openstack.org/cgit/openstack/python-ironicclient/tree/ironicclient/openstack/common/apiclient/exceptions.py#n447

[Lucas Alvares Gomes (lucasagomes)]

Will take a look at it

[Lucas Alvares Gomes (lucasagomes)]

I did a fresh OS install and run DevStack, but can't reproduce the error:

stack@virtual-machine:~/devstack$ source ~/devstack/accrc/admin/admin
stack@virtual-machine:~/devstack$ ironic node-list
+--------------------------------------+---------------+-------------+--------------------+-------------+
| UUID | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+---------------+-------------+--------------------+-------------+
| ffc8f739-9e17-4c71-a975-ff67a1751fdf | None | power off | None | False |
+--------------------------------------+---------------+-------------+--------------------+-------------+

stack@virtual-machine:~/devstack$ export OS_USERNAME=demo
stack@virtual-machine:~/devstack$ ironic node-list
Authentication failure: User f0754e749a38445cbcf00eb6ce7e1655 is unauthorized for tenant b944b45f565d4d26a07dfd478a63f997 (Disable debug mode to suppress these details.) (HTTP 401)
stack@virtual-machine:~/devstack$ export OS_USERNAME=aaaaaaaa
stack@virtual-machine:~/devstack$ ironic node-list
Authentication failure: Could not find user: aaaaaaaa (Disable debug mode to suppress these details.) (HTTP 401)

[Lucas Alvares Gomes (lucasagomes)]

Oh right, doing a request with a missing parameter (for e.g node-create w/o the driver) and a valid user seems to make the error apparently:

stack@virtual-machine:~/devstack$ source ~/devstack/accrc/admin/admin
stack@virtual-machine:~/devstack$ ironic node-create -i test=test
'unicode' object has no attribute 'get'

[John Trowbridge (trown)]

I can reproduce Lucas' example. I can't reproduce the issue with node-list.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/132033

[Lucas Alvares Gomes (lucasagomes)]

The error is here: https://github.com/openstack/python-ironicclient/blob/master/ironicclient/openstack/common/apiclient/exceptions.py#L433

Sync'ing the apiclient module from oslo fix the problem

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/132033
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=8d7a2e4f32978b9ef7c33b6703d5bc30f07fa572
Submitter: Jenkins
Branch: master

commit 8d7a2e4f32978b9ef7c33b6703d5bc30f07fa572
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 30 14:29:58 2014 +0000

    Sync apiclient from Oslo

    Sync'ing apiclient from Oslo to fix the "'unicode' object has no attribute
    'get'" problem.

    Closes-Bug: #1386470
    Change-Id: I46233c04a95c6441ae86572915f4492c6c1a48c5