OpenStack Heat

Traceback instead of error message when output or resource body is empty or a string

Bug #1386242 reported by Peter Razumovsky on 2014-10-27

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Heat	Fix Released	Undecided	Peter Razumovsky	OpenStack Heat 2015.1.0 "kilo"

Bug Description

1) Empty output body.
1.
heat_template_version: 2013-05-23
parameters:
  image:
    type: string
resources:
  server:
    type: OS::Nova::Server
    properties:
      image: { get_param: image }
      flavor: m1.small
outputs:
  output1:
2.
$ heat stack-create test -f test.yaml -P image=test
ERROR: 'NoneType' object has no attribute 'iteritems'
Traceback (most recent call last):

File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 134, in _dispatch_and_reply
incoming.message))

File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 177, in _dispatch
return self._do_dispatch(endpoint, method, ctxt, args)

File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 123, in _do_dispatch
result = getattr(endpoint, method)(ctxt, **new_args)

File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
return f(*args, **kwargs)

File "/opt/stack/heat/heat/engine/service.py", line 73, in wrapped
return func(self, ctx, *args, **kwargs)

File "/opt/stack/heat/heat/engine/service.py", line 663, in create_stack
owner_id)

File "/opt/stack/heat/heat/engine/service.py", line 583, in _parse_template_and_validate_stack
**common_params)

File "/opt/stack/heat/heat/engine/stack.py", line 135, in __init__
self.outputs = self.resolve_static_data(self.t[self.t.OUTPUTS])

File "/opt/stack/heat/heat/engine/hot/template.py", line 108, in __getitem__
return self._translate_outputs(the_section)

File "/opt/stack/heat/heat/engine/hot/template.py", line 158, in _translate_outputs
for attr, attr_value in six.iteritems(attrs):

File "/usr/local/lib/python2.7/dist-packages/six.py", line 565, in iteritems
return iter(d.iteritems(**kw))

AttributeError: 'NoneType' object has no attribute 'iteritems'

2) Empty resource body
1.
heat_template_version: 2013-05-23
parameters:
  image:
    type: string
resources:
  server:
2.
$ heat stack-create test -f test.yaml -P image=test
ERROR: 'NoneType' object has no attribute 'iteritems'
Traceback (most recent call last):

File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 134, in _dispatch_and_reply
incoming.message))

File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 177, in _dispatch
return self._do_dispatch(endpoint, method, ctxt, args)

File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 123, in _do_dispatch
result = getattr(endpoint, method)(ctxt, **new_args)

File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
return f(*args, **kwargs)

File "/opt/stack/heat/heat/engine/service.py", line 73, in wrapped
return func(self, ctx, *args, **kwargs)

File "/opt/stack/heat/heat/engine/service.py", line 705, in update_stack
if len(tmpl[tmpl.RESOURCES]) > cfg.CONF.max_resources_per_stack:

File "/opt/stack/heat/heat/engine/hot/template.py", line 105, in __getitem__
return self._translate_resources(the_section)

File "/opt/stack/heat/heat/engine/hot/template.py", line 138, in _translate_resources
for attr, attr_value in six.iteritems(attrs):

File "/usr/local/lib/python2.7/dist-packages/six.py", line 565, in iteritems
return iter(d.iteritems(**kw))

AttributeError: 'NoneType' object has no attribute 'iteritems'

3) Output body is a string
1.
heat_template_version: 2013-05-23
resources:
  server:
    type: OS::Nova::Server
    properties:
      flavor: m1.small
outputs:
  output1:
    This is not a string, this is error-raisable situation
2.
$ heat stack-create test -f test.yaml
ERROR: 'unicode' object has no attribute 'iteritems'
Traceback (most recent call last):