Selecting a map in multiplayer mode crashes the game

[SirVer]

Multiplayer -> LAN -> Host a game -> "Map" -> doubleclick on any map crashes the game:

Application Specific Information:
abort() called
terminating with uncaught exception of type ImageNotFound: [/Users/sirver/Desktop/Programming/cpp/widelands/bzr_repo/src/graphic/image_io.h:34] Image not found:

[SirVer (sirver)]

The immediate crash is fixed in r7225.

The problem was code like this:

char* b;
b = boost::format(...).str().c_str();

the problem is that the call to str() will create a std::string() that is then immediately destroyed again. The system is free to reuse the memory that c_str() is pointing to again (since it belonged to the deleted std::string()). In some cases it will do that, in some it will not - that is why the crash happens on some systems but not all.

I grepped through the code base ('format.*c_str') and found more cases where this is happening - note that this is no guarantee that fixing all these removes the problem forever, as code like this is not found but is broken too:

const char* b;
{
   std::string a = format().str();
   b = a.c_str();
}
// the data b is pointing to is undefined here and should not be used.

But the easily greppable cases must be fixed quickly.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.