Swift multi-tenant store: upload broken

Bug #1385213 reported by Stuart McLaren
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Stuart McLaren
Juno
Fix Released
High
Stuart McLaren
glance_store
Fix Released
Undecided
Unassigned

Bug Description

glance image-upload xxx

returns E500 when using the swift multi-tenant backend

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/130755
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=3bb94dcad84ed4204d8809fcf95b7713daa2189b
Submitter: Jenkins
Branch: master

commit 3bb94dcad84ed4204d8809fcf95b7713daa2189b
Author: Stuart McLaren <email address hidden>
Date: Fri Oct 24 11:29:15 2014 +0000

    Swift Multi-tenant store: Fix image upload

    Image upload returns an E500 as the token is not being
    passed to the swift client.

    Change-Id: I1246661ab0bc392b5d33cb53cb81412bd633e4b3
    Closes-bug: #1385213

Changed in glance:
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/130757
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=867b696d884e9db707683eecd321789843798efd
Submitter: Jenkins
Branch: master

commit 867b696d884e9db707683eecd321789843798efd
Author: Stuart McLaren <email address hidden>
Date: Fri Oct 24 10:42:44 2014 +0000

    Swift Multi-tenant store: Pass context on upload

    Image upload returns an E500 as the context is not being
    passed to the swift client.

    Change-Id: I2065b7dd281bfbb513f13270a0c062fc7132f763
    Partial-bug: 1385213

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132270

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/131478
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=cc7ae2abd5c67b5573ca609e27c79d5c4f9a528d
Submitter: Jenkins
Branch: master

commit cc7ae2abd5c67b5573ca609e27c79d5c4f9a528d
Author: Stuart McLaren <email address hidden>
Date: Tue Oct 28 14:26:54 2014 +0000

    Make RequestContext use auth_token (not auth_tok)

    The RequestContext class from oslo-incubator uses 'auth_token'.
    Glance's RequestContext uses 'auth_tok' -- which is inconsistent.

    glance_store currently uses the oslo 'auth_token'.

    We should not assume a 1-1 mapping from the glance_store to glance,
    nor should we have glance_store support both 'auth_token' and
    'auth_tok'. Therefore Glance should be updated to use 'auth_token'.

    This change was generated automatically with:

    $ for file in `find glance -name '*\.py' -exec grep -wl auth_tok "{}" \;` ; \
      do sed --in-place 's/\<auth_tok\>/auth_token/g' $file ; done

    In addition, the set_auth_token function was removed. This had been used
    by Nova to work around the auth_tok <-> auth_token inconsistency, but
    was removed in mid-2012 as part of the move to python-glanceclient so
    is no longer needed.

    In conjuction with other changes this fixes image upload when
    using the multi-tenant Swift store.

    Change-Id: Ic8a5f44088990fd8f6290a5622b823f59ef365fc
    Partial-bug: #1385213

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/131481
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=e284f8c080c87acdc2757e0fe16063214c2988be
Submitter: Jenkins
Branch: master

commit e284f8c080c87acdc2757e0fe16063214c2988be
Author: Stuart McLaren <email address hidden>
Date: Tue Oct 28 15:49:48 2014 +0000

    Move cinder store to use auth_token

    The cinder store uses auth_tok. This should be
    changed to use auth_token as the glance request
    context is changing: https://review.openstack.org/#/c/131478/

    Change-Id: Id8a920d7035de111ce3fde54d62f35a07a9a7851
    Partial-bug: #1385213

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/134257

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/134286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/134289

Alan Pevec (apevec)
Changed in glance:
assignee: nobody → Stuart McLaren (stuart-mclaren)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/juno)

Reviewed: https://review.openstack.org/134257
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=10a698536377b86424d15121942f199535f67d58
Submitter: Jenkins
Branch: stable/juno

commit 10a698536377b86424d15121942f199535f67d58
Author: Stuart McLaren <email address hidden>
Date: Fri Oct 24 10:42:44 2014 +0000

    Swift Multi-tenant store: Pass context on upload

    Image upload returns an E500 as the context is not being
    passed to the swift client.

    Change-Id: I2065b7dd281bfbb513f13270a0c062fc7132f763
    Partial-bug: 1385213
    (cherry picked from commit 867b696d884e9db707683eecd321789843798efd)

tags: added: in-stable-juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/134286
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=be90df80c47ca5f26a36e4926ba9f129c4922358
Submitter: Jenkins
Branch: stable/juno

commit be90df80c47ca5f26a36e4926ba9f129c4922358
Author: Stuart McLaren <email address hidden>
Date: Tue Oct 28 14:26:54 2014 +0000

    Make RequestContext use auth_token (not auth_tok)

    The RequestContext class from oslo-incubator uses 'auth_token'.
    Glance's RequestContext uses 'auth_tok' -- which is inconsistent.

    glance_store currently uses the oslo 'auth_token'.

    We should not assume a 1-1 mapping from the glance_store to glance,
    nor should we have glance_store support both 'auth_token' and
    'auth_tok'. Therefore Glance should be updated to use 'auth_token'.

    This change was generated automatically with:

    $ for file in `find glance -name '*\.py' -exec grep -wl auth_tok "{}" \;` ; \
      do sed --in-place 's/\<auth_tok\>/auth_token/g' $file ; done

    In addition, the set_auth_token function was removed. This had been used
    by Nova to work around the auth_tok <-> auth_token inconsistency, but
    was removed in mid-2012 as part of the move to python-glanceclient so
    is no longer needed.

    In conjuction with other changes this fixes image upload when
    using the multi-tenant Swift store.

    Change-Id: Ic8a5f44088990fd8f6290a5622b823f59ef365fc
    Partial-bug: #1385213
    (cherry picked from commit cc7ae2abd5c67b5573ca609e27c79d5c4f9a528d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/juno)

Change abandoned by Alan Pevec (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/134289
Reason: bot will sync this from openstack/requirements once accepted there

Revision history for this message
Louis Taylor (kragniz) wrote :

Glance_store fixes for this were released in 0.1.10.

Changed in glance-store:
status: New → Fix Released
Louis Taylor (kragniz)
Changed in glance:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Stuart McLaren (<email address hidden>) on branch: master
Review: https://review.openstack.org/132270

Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.