Network Topology view for tenant shows other tenant networks as well

[Vidyut]

Login as tenant "A", create couple of networks:
- Network 1, external network shared.
- Network 2, external network (not-shared).

Now Login as tenant "B", go to project and network listing page:
- At this page, we see only shared network.
- When we navigate to Network Topology view, both the networks (created under tenant "A") can be seen.

This is a discrepancy across 2 view (Network Listing and Network Topology) view trying to show similar information.

[Akihiro Motoki (amotoki)]

This was the past behavior. When the bug was reported, external networks are not shown in the network table. At that time, networks which regular tenants can create a port were shown in the table. In the network topology, external networks were shown as this panel shows a network topology. External networks mean a kind of an external world so it is reasonable.

After that, the network table was changed to show external networks since users want to know external networks as floating IP pools.

As a result, the issue reported here has been addressed.

[Dmitriy Rabotyagov (noonedeadpunk)]

Hi,

It seems a bit strange now in Pike, when in network list user may see networks, which had been created as not shared ones.
When in https://github.com/openstack/horizon/blob/9ca9b5cd81db29bddf6dbcc5fc535009a9ec63b0/openstack_dashboard/dashboards/project/networks/views.py#L55 I set include_external=False - it's exact behavior I expect to see in Horizon:
1. External shared networks are shown
2. External not shared networks are hidden, when non-owner or non-admin opens Network Listing.

Probably it's worth to move this to the settings, if behaviour when everyone sees non-shared external networks important?