[IT] MapR unit tests setting os_region_name incorrectly

Bug #1384875 reported by Trevor McKay
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
High
Trevor McKay

Bug Description

Some of the MapR plugin unit tests assign os_region_name directly. This breaks the __gettattr__ behavior for config options in oslo.config, so overrides are not seen. When the MapR tests run first in a worker which later runs tests using os_region_name overrides, those tests fail (for example, test_url_for_regions).

The MapR tests should not set the value at all (the default None, set to None) or should set the override value

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/130628

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/130628
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=ef1283311946c019b4512090e51da06a3bc694c0
Submitter: Jenkins
Branch: master

commit ef1283311946c019b4512090e51da06a3bc694c0
Author: Trevor McKay <email address hidden>
Date: Thu Oct 23 15:33:47 2014 -0400

    Remove explicit set of CONF.os_region_name in mapr plugin tests

    The explicit set of os_region_name to None breaks subsequent
    unit tests running in the same worker process that attempt to
    override os_region_name. Any setting of os_region_name in unit
    tests should use the set_override or set_default methods available
    in oslo.config.

    Close-bug: 1384875
    Change-Id: Iea2eb58dc3d8e8667795495c6cc1f68538d524b6

Changed in sahara:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in sahara:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.