nova-network doesn't create SNAT rules if CONF.force_snat_range is not set

[Sergii Golovatiuk]

In Juno network-network no longer creates SNAT rules for new networks if CONF.force_snat_range is not set to '0.0.0.0/0'.

This was changed in 59ac254bf15bb059cca12a82c9d819c371ea5c6f (https://review.openstack.org/#/c/94112/), which treats external gateway in a special way (though, in this case, it's not an external gateway).

Curiously, those rules will be created when nova-network process is restarted (must be something 59ac254bf15bb059cca12a82c9d819c371ea5c6f didn't intend to do).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/130488

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/130488
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=65fc70f4d84177e3d512bf930244174fe57f24c8
Submitter: Jenkins
Branch: master

commit 65fc70f4d84177e3d512bf930244174fe57f24c8
Author: Sergii Golovatiuk <email address hidden>
Date: Thu Oct 23 12:36:48 2014 +0200

    Set force_snat_range parameter

    Due to change 59ac254bf15bb059cca12a82c9d819c371ea5c6f merged in Juno
    Nova-network checks whether network has external gateway and does
    (which it has by default) and does not create SNAT rules for the instances
    if list of force snat ranges is empty now.

    This change sets force_snat_range to ANY network and thus
    new code adds corresponding rules.

    Change-Id: I339dd09543f2900cab3ba6164207e962229e4386
    Closes-Bug: 1384661
    Signed-off-by: Sergii Golovatiuk <email address hidden>