angular humanizeNumbers utility is not internationalized

Bug #1384462 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Albert Tu

Bug Description

While browsing code I ran across
horizon/static/horizon/js/angular/services/horizon.utils.js#L25

 humanizeNumbers: function (number) {
return number.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
},

which is not a proper way to group numbers in all locales.

http://en.wikipedia.org/wiki/Decimal_mark#Other_numeral_systems , Examples of use shows various internationalized examples.

Doug Fish (drfish)
tags: added: i18n
Doug Fish (drfish)
summary: - our angular humanizeNumbers utility is not internationalized
+ angular humanizeNumbers utility is not internationalized
Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
utsav dusad (utsavdusad)
Changed in horizon:
assignee: nobody → utsav dusad (utsavdusad)
utsav dusad (utsavdusad)
Changed in horizon:
assignee: utsav dusad (utsavdusad) → nobody
Albert Tu (albert-t-8)
Changed in horizon:
assignee: nobody → Albert Tu (albert-t-8)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/199997

Changed in horizon:
status: Confirmed → In Progress
Doug Fish (drfish)
Changed in horizon:
importance: Low → Medium
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/199997
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/199997
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=89d0304d19e5789bc5b42b30e39e1e71a7f2bdfe
Submitter: Jenkins
Branch: master

commit 89d0304d19e5789bc5b42b30e39e1e71a7f2bdfe
Author: Albert Tu <email address hidden>
Date: Thu Oct 20 15:31:23 2016 +0800

    Add i18n support to Quota.humanizeNumbers

    Show localized number format via ECMAScript i18n API.

    Closes-Bug: #1384462

    Change-Id: Ia8ca3c93c157bfb791f711529d60ce610b3686fe

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b2

This issue was fixed in the openstack/horizon 11.0.0.0b2 development milestone.

Changed in horizon:
milestone: none → ocata-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/420790

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/420790
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8cc1935fcfeae1ee02f04e67c71ed8abc5bf4389
Submitter: Jenkins
Branch: stable/newton

commit 8cc1935fcfeae1ee02f04e67c71ed8abc5bf4389
Author: Albert Tu <email address hidden>
Date: Thu Oct 20 15:31:23 2016 +0800

    Add i18n support to Quota.humanizeNumbers

    Show localized number format via ECMAScript i18n API.

    Closes-Bug: #1384462

    Change-Id: Ia8ca3c93c157bfb791f711529d60ce610b3686fe
    (cherry picked from commit 89d0304d19e5789bc5b42b30e39e1e71a7f2bdfe)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.2

This issue was fixed in the openstack/horizon 10.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.