Snapshot volume backed VM does not handle image metadata correctly

[Samuel Matzek]

Nova Juno

The instance snapshot of volume backed instances does not handle image metadata the same way that the regular instance snapshot path does.

nova/compute/api/api.py's snapshot path builds the Glance image metadata using nova/compute/utils.py get_image_metadata which gets metadata from the VM's base image, includes metadata from the instance's system metadata, and excludes properties specified in CONF.non_inheritable_image_properties.

The volume backed snapshot path, http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/servers.py#n1472 simply gets the image properties from the base image and does not include properties from instance system metadata and doesn't honor the CONF.non_inheritable_image_properties property.

[Alex Xu (xuhj)]

This is fixed by https://review.openstack.org/#/c/170243/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/198959
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6b93494bfda1385244fed3bbadbe2a26b38f9a09
Submitter: Jenkins
Branch: master

commit 6b93494bfda1385244fed3bbadbe2a26b38f9a09
Author: Feodor Tersin <email address hidden>
Date: Tue Jul 7 07:33:34 2015 +0300

    Consolidate initialization of instance snapshot metadata

    Both types of instance snapshots (volume-backed and image-based) require
    similar metadata with a few differences. This patch introduces a common
    method for initialization of instance snapshot metadata and uses it in
    the custom cases.

    Also this fixes a bug for volume-backed instance snapshots: properties
    restricted to be inherited by config are inherited though.

    Closes-Bug: #1384392
    Change-Id: I811405bbe98e391f76b868cd35b03ca3dced8cdd