Cinder

Cinder needs to get onboard with i18n markers

Bug #1384312 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Mike Mason
Cinder 2015.1.0 "kilo"

Bug Description

Everybody has used to using the _L'x' markers but on the Cinder team we'd hoped to find a cleaner alternative. It's been several weeks and that hasn't happened so at this point we need to get in line.

If somebody does come up with an alternate proposal so beit, we'll cross that bridge when we get to it. Meanwhile we can't sit in limbo on this.

John Griffith (john-griffith)
Changed in cinder:
status: New → Triaged
milestone: none → kilo-1
importance: Undecided → Medium
Jay Bryant (jsbryant)
Changed in cinder:
status: Triaged → Confirmed
importance: Medium → High
Duncan Thomas (duncan-thomas)
Changed in cinder:
assignee: nobody → Mike Mason (mikemason010)
Revision history for this message
John Griffith (john-griffith) wrote :

Suggested strategy if interested, submit patches in a series one for each subdirectory in cinder.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/130529

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/130529
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7e7ea5a609c87039c48cc9805e7416adbafd9f3b
Submitter: Jenkins
Branch: master

commit 7e7ea5a609c87039c48cc9805e7416adbafd9f3b
Author: Mike Mason <email address hidden>
Date: Thu Oct 23 13:16:42 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.

    Partial-Bug: #1384312

    Change-Id: I62c708036a9cd5da431b7a95e9cd41167fb5273b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132698

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/133033

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/133528

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mike Mason (<email address hidden>) on branch: master
Review: https://review.openstack.org/133528

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133637

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/133942

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/133942
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=18544b9323c3154cc9eb3e8e4012dc4118009e4d
Submitter: Jenkins
Branch: master

commit 18544b9323c3154cc9eb3e8e4012dc4118009e4d
Author: Mike Mason <email address hidden>
Date: Tue Nov 11 14:05:24 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.
    This is the fifth commit of this kind

    Change-Id: I476750bf05ddee85dd5bf25c7bd00ee103d23115
    Partial-Bug: #1384312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/133033
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=abedc103430ee5d0fc34a1228cf25fe4f35baa5b
Submitter: Jenkins
Branch: master

commit abedc103430ee5d0fc34a1228cf25fe4f35baa5b
Author: Mike Mason <email address hidden>
Date: Thu Nov 6 13:37:37 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.
    This is the third commit of this kind

    Change-Id: I33b0bb05b1c1ea91dc5a1e93eaadceea1f23fcc9
    Partial-Bug: #1384312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/134918
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dbd111f87deb9a4636e466b9d75c76bf981cf8e5
Submitter: Jenkins
Branch: master

commit dbd111f87deb9a4636e466b9d75c76bf981cf8e5
Author: Mike Mason <email address hidden>
Date: Mon Nov 17 09:58:10 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.
    This is the sixth commit of this kind

    Partial-Bug: #1384312

    Change-Id: I42b4e168deec9930571c1869fe1a181d4aad1112

OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Mike Mason (mikemason010) → Walt Boring (walter-boring)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/135786
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=433f25f30fd9d786a581b318674b5c7caecd7b63
Submitter: Jenkins
Branch: master

commit 433f25f30fd9d786a581b318674b5c7caecd7b63
Author: Walter A. Boring IV <email address hidden>
Date: Wed Nov 19 15:52:56 2014 -0800

    Fix message translations for MSA common class

    This patch adds the crazy _LI, _LE, _LW markers for
    the MSA class for each of the appropriate LOG.info,
    LOG.error and LOG.warning calls.

    Change-Id: I831db878f1d51cdf61049a6fd8302d2464d477d5
    Partial-Bug: #1384312

OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Walt Boring (walter-boring) → Mike Mason (mikemason010)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/133637
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1fd4c55c85549ef066597b69c05c15dbb975405a
Submitter: Jenkins
Branch: master

commit 1fd4c55c85549ef066597b69c05c15dbb975405a
Author: Mike Mason <email address hidden>
Date: Tue Nov 11 09:11:29 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.
    This is the fourth commit of this kind

    Change-Id: Ibbef7f06a391e9e6efca082d45caecdf60a9e811
    Partial-Bug: #1384312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137244

Changed in cinder:
assignee: Mike Mason (mikemason010) → Jay Bryant (jsbryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/132698
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f69c40ebb40714c15bcb983643b93a6ba2f5424c
Submitter: Jenkins
Branch: master

commit f69c40ebb40714c15bcb983643b93a6ba2f5424c
Author: Mike Mason <email address hidden>
Date: Tue Nov 25 15:57:24 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.

    Partial-Bug: #1384312

    Change-Id: I3974b58bd9b8b9e3c34d5a609228e30c6a08a3c3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138997

Changed in cinder:
assignee: Jay Bryant (jsbryant) → Mike Mason (mikemason010)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/138997
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9ad858c9c9522eac8b653b633c04669b39bc2b5c
Submitter: Jenkins
Branch: master

commit 9ad858c9c9522eac8b653b633c04669b39bc2b5c
Author: Mike Mason <email address hidden>
Date: Thu Dec 4 09:17:57 2014 +0000

    Implementing the use of _L’x’/i18n markers

    Placing the _Lx markers back into the code. No other cleaner solution has
    has been implemented. Patches will be submitted in a series of sub
    directories and in a fashion that is manageable.
    eighth commit of this kind
    This is the last run through to pick up the ones that were missed

    Change-Id: Ifd9d647175a840939bf01fa3bcecfa6384965e3b
    Closes-Bug: #1384312

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142868

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/137244
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f98677dae91ae47d57063901bbfd72a8106af14a
Submitter: Jenkins
Branch: master

commit f98677dae91ae47d57063901bbfd72a8106af14a
Author: Jay S. Bryant <email address hidden>
Date: Tue Nov 25 18:10:15 2014 -0600

    Make GPFS driver compliant with logging standards

    This patch adds the log level markers (_LI, _LE or _LW) where they
    were missing. It also changes the use of '%' to ',' for inserting
    variables into log messages. These changes are made based on the
    guidelines in:
    http://docs.openstack.org/developer/oslo.i18n/guidelines.html

    Change-Id: I46dc4855776638a133a65451c7e32269dd09b8d1
    Partial-Bug: 1384312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144402

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/142868
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f303389810aa8945a2967fc81783d3d4a54f1e16
Submitter: Jenkins
Branch: master

commit f303389810aa8945a2967fc81783d3d4a54f1e16
Author: Walter A. Boring IV <email address hidden>
Date: Thu Dec 18 18:24:50 2014 +0000

    Make 3PAR drivers compliant with logging standards

    The guidelines are specified here:
    http://docs.openstack.org/developer/oslo.i18n/guidelines.html

    Change-Id: I79beb65d94d338ccd96df789691c96b86ddbaac2
    Partial-Bug: 1384312

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/144402
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cc3ec5824ef3f91e14eeba2d3b3a1a5efceebd42
Submitter: Jenkins
Branch: master

commit cc3ec5824ef3f91e14eeba2d3b3a1a5efceebd42
Author: rick.chen <email address hidden>
Date: Tue Dec 30 12:11:18 2014 +0800

    Make ProphetStor drivers compliant with logging standards

    The guidelines are specified here:
    http://docs.openstack.org/developer/oslo.i18n/guidelines.html

    Change-Id: I9e76f3159ee6fbee2c7394aa59ac05f5904ae1cb
    Partial-Bug: 1384312

Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.