xenapi auto disk config uses wrong size value when booting from volume

[Andrew Laski]

The auto disk config setting to resize a guest filesystem on boot in the xenapi driver can destroy the partition when booting from a volume. The end result of which is the following error during boot:

nova-compute.log:2014-10-10 16:04:30.829 19672 TRACE nova.utils [instance: uuid] raise Failure(result['ErrorDescription'])
nova-compute.log:2014-10-10 16:04:30.829 19672 TRACE nova.utils [instance: uuid] Failure: ['BOOTLOADER_FAILED', 'OpaqueRef:cd142319-cf6e-c2eb-8c1d-b303a5157ac2', 'Disk has no partitions\n']

This happens because auto_disk_config gets a size value from the flavor root_gb setting, but when booting from a volume this value is ignored in favor of the volume size. This can lead to unexpected behavior when volume size > root_gb, and the above error when volume size < root_gb.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/130038

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/130038
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Removing "In Progress" status and assignee as change is abandoned.

[Markus Zoeller (markus_z) (mzoeller)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY