Deprecate catalog replacements and whitelists

[David Stanek]

Bug #1354208 reported a security flaw in the way that we performed substitution for catalog URLs. The immediate solution was to add a whitelist of config fields that are safe to use with substitution. The long term goal is to get rid of this feature and only allow tenant_id and user_id to be used for substitution.

The first step for the Kilo release is to deprecate the feature.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/130013

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Stanek (<email address hidden>) on branch: master
Review: https://review.openstack.org/130013
Reason: Abandoning in favor of Brant's patch: https://review.openstack.org/#/c/131007/

[huangpengtaohw (huangpengtao)]

in line 896 the function _config_to_list is not working well,
the return volue (whitelisted, sensitiveto) is alwayle []

[David Stanek (dstanek)]

huangpengtao, Can you provide a test case that shows the bad behavior? Eye balling the code it looks OK, although I can see why it would look like the return value is alway ([], []). The reason this is not the case is that 'the_list' is used as an alias for 'whitelisted' and 'sensitive'.

If you truly think there is a bug please create a new bug with the details.