Wrong name of Cinder role in case of vCenter

[okosse]

When using vCenter as a hypervisor, it's allowed to use VMWare vCenter as a storage backend for Cinder. However, the role for Cinder is named as 'Storage - Cinder LVM' which is wrong.

---------------------fuel-version---------------------------------
api: '1.0'
astute_sha: 6a11a7c481d116e6cfdb422fab1d4bbb29cbea1c
auth_required: true
build_id: 2014-10-20_00-01-06
build_number: '20'
feature_groups:
- mirantis
fuellib_sha: 598f2b7212f686559630752a3d2e68569541172b
fuelmain_sha: 598122bd61175a96a71a1ab76818d5d67529cdb7
nailgun_sha: 098099ccce353eb38f8440fa0b1c5fbc5a84d784
ostf_sha: de177931b53fbe9655502b73d03910b8118e25f1
production: docker
release: '6.0'
release_versions:
  2014.1.1-6.0:
    VERSION:
      api: '1.0'
      astute_sha: 6a11a7c481d116e6cfdb422fab1d4bbb29cbea1c
      build_id: 2014-10-20_00-01-06
      build_number: '20'
      feature_groups:
      - mirantis
      fuellib_sha: 598f2b7212f686559630752a3d2e68569541172b
      fuelmain_sha: 598122bd61175a96a71a1ab76818d5d67529cdb7
      nailgun_sha: 098099ccce353eb38f8440fa0b1c5fbc5a84d784
      ostf_sha: de177931b53fbe9655502b73d03910b8118e25f1
      production: docker
      release: '6.0'

[Andrey Danin (gcon-monolake)]

Actually, this is the way how we implemented that in MOS 5.x. Cinder-volume service is running only when you assign "Storage - Cinder LVM" role to a node. So, there may be two ways to fix that:
1. Modify a UI to change a name of this role to something like "Cinder VMDK".
2. Refactor Puppet manifests to run Cinder-volume services on Controller nodes every time a user choose vCenter as a hypervisor. In this case we don't need a special role for installing Cinder.

I prefer the second approach.

Also, this behavior must be documented for 5.1.1, because I don't think it's a good idea to port this huge changes back.

[Andrey Danin (gcon-monolake)]

We have to:
1. Explicitly describe the situation with wrong role name in documentation for 5.1.1 and for 6.0.
2. Warn a user on UI in a role description that this role should be used when he or she wants to use Cinder with vCenter (for 5.1.1 and 6.0).
3. Postpone an accurate fix of the bug to 6.1.

[Roman Prykhodchenko (romcheg)]

IIUC, the problem is only in the naming. If so, isn't it just possible to introduce more generic name and description in openstack.yaml like I did here https://review.openstack.org/136845 ?

[Andrey Danin (gcon-monolake)]

Roman, it can be done as you suggested. But in this case we'll have to fix our documentation a little bit and renew some pictures in it.

[Andrey Danin (gcon-monolake)]

As this is a cosmetic issue and we are near Code Freeze for 5.1.1, let fix it in 6.0 only. I'm closing the bug for 5.1.x series. This bug will be described in Release Notes as a known issue by this patch set https://review.openstack.org/#/c/130717

[Roman Prykhodchenko (romcheg)]

Mike pre-approved this approach so I set the patch to touch this bug and it can be reviewed now.
Andrey, thank you for your notice regarding the documentation. I've added the DocImpact token so the once the change gets merged I will be noticed by the fuel-docs team.

[Andrey Danin (gcon-monolake)]

HCFis almost there. So move move it to 6.0.1 and 6.1.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136845
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=54c502550b215b366580930a59aef95d27e3b7f9
Submitter: Jenkins
Branch: master

commit 54c502550b215b366580930a59aef95d27e3b7f9
Author: Roman Prykhodchenko <email address hidden>
Date: Mon Nov 24 18:45:52 2014 +0100

    Rename Cinder role

    The name and the description of the storage role in openstack.yaml
    was hardcoded to mention that this role provides block storage over
    iSCSI and uses LVM. That is not true for cases when VMware vCenter
    is used as a back-end for storage.

    This patch changes those name and description to more common ones.
    After this is merged it's required to update screenshotsi, referencesand
    descriptions in at least the followind docs:

     * User guide
     * Reference Architectures
     * Fuel developer's documentation

    DocImpact
    Closes-bug: 1383224
    Change-Id: I4aa013611242ff6b7e6e0889b38bfbf9e9a700ec

[Roman Prykhodchenko (romcheg)]

Moving one notice from review for further releases:

Dmitry Borodaenko 12:40 AM

Patch Set 6:
While I agree on principle with this change, there's an important problem that the new role name fails to address.
When using Ceph RBD backend for Cinder, cinder-volume is deployed on controllers and you don't need dedicated Cinder nodes (in fact you can't have dedicated Cinder nodes because we don't support multiple Cinder backends). Having LVM in the name indicates that this role is specific to the LVM backend for Cinder, and even that indication is not enough to steer some people away from assigning this role while deploying a Ceph backed cloud. Relying on documentation to explain this is not enough since most users tend to refer to documentation after they tried and failed to deploy a cloud, not before they've started.
Any ideas on how to address this problem while renaming "Storage - Cinder LVM" to "Storage - Cinder"?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138747

[Irina Povolotskaya (ipovolotskaya)]

Added Closes-Bug tag to document this change (replace a screenshot).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138747
Committed: https://git.openstack.org/cgit/stackforge/fuel-docs/commit/?id=3b8bf57a9ffc5f187feaac7b2f568bee07134d22
Submitter: Jenkins
Branch: master

commit 3b8bf57a9ffc5f187feaac7b2f568bee07134d22
Author: irina povolotskaya <email address hidden>
Date: Wed Dec 3 17:30:50 2014 +0300

    Update 'Cinder-LVM' role screenshot

    Since this role was renamed, let's update our guides where assigning roles
    is mentioned.

    Change-Id: Ifbd0719055eb198097284cd2910342757f3eb720
    Closes-Bug: 1383224

[okosse (okosse)]

I checked it on fuel-6.0-56-2014-12-18_01-32-01.iso