call generate clientmanager once in interactive mode

Bug #1383083 reported by wanghong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
wanghong

Bug Description

In interactive mode, OpenStackShell will still call prepare_to_run_command method before run command, and, in prepare_to_run_command method we will generate a clientmanager instance. So, we are repeated to generate clientmanager instance when run command.

I think, this should be avoided, we should only generate one clientmanager instance in interactive mode.

wanghong (w-wanghong)
Changed in python-openstackclient:
assignee: nobody → wanghong (w-wanghong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129537

Changed in python-openstackclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/129537
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=f600c0eafbf9aff23b6efa1c7b94797a25873b99
Submitter: Jenkins
Branch: master

commit f600c0eafbf9aff23b6efa1c7b94797a25873b99
Author: wanghong <email address hidden>
Date: Mon Oct 20 15:29:53 2014 +0800

    only generate one clientmanager instance in interactive mode

    Currently, we repeated to generate clientmanager instance when run
    command in interactive mode. This should be avoided.

    Change-Id: I0536a690bc173be38af08a2e4443115532041efd
    Closes-Bug: #1383083

Changed in python-openstackclient:
status: In Progress → Fix Committed
Dean Troyer (dtroyer)
Changed in python-openstackclient:
milestone: none → m6
summary: - repeated to generate clientmanager in interactive mode
+ call generate clientmanager once in interactive mode
Dean Troyer (dtroyer)
Changed in python-openstackclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.