pipe not closed with use of popen

[Simon]

In keystoneclient.common.cms, subprocess.Popen is used to get the output of openssl execution. After running keystone for a while, there are many open pipes and eventually causing keystone to stop working because of open file limit.

[Simon (xchenum)]

I submitted a patch to set close_fds=True in Popen - it at least solves the problem for my environment.

[Simon (xchenum)]

https://review.openstack.org/#/c/129456

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129456
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=f00755f04ac5298c86620592af1c65acb0f021ae
Submitter: Jenkins
Branch: master

commit f00755f04ac5298c86620592af1c65acb0f021ae
Author: Xu (Simon) Chen <email address hidden>
Date: Sat Oct 18 23:00:01 2014 -0400

    set close_fds=True in Popen

    The current way of using Popen does not close pipes properly,
    and therefore long-running keystone processes, which depends on
    keystoneclient.common.cms for data sigining, eventually hit
    open file limit and stop working. Passing close_fds=True seems
    to have solved the problem.

    Change-Id: Ife452ab6843c1af5eb39debb8db453e45f78cba9
    Closes-Bug: 1382906