Translatable string "on" is too short to translate

Bug #1382874 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

The following string is too short to translate and string concatenation is used.

#: dashboards/project/instances/templates/instances/_detail_overview.html:135
#: dashboards/project/volumes/templates/volumes/volumes/_detail_overview.html:43
msgid "on"
msgstr ""

openstack_dashboard/dashboards/project/instances/templates/instances/_detail_overview.html

            <a href="{% url 'horizon:project:volumes:volumes:detail' volume.id %}">
            {% if volume.name %}
                {{ volume.name }}
            {% else %}
                {{ volume.id }}
            {% endif %}
            </a>
            <span> {% trans "on" %} {{ volume.device }}</span>

openstack_dashboard/dashboards/project/volumes/templates/volumes/volumes/_detail_overview.html

        {% url 'horizon:project:instances:detail' attachment.server_id as instance_url%}
        <a href="{{ instance_url }}">{{ attachment.instance.name }}</a>
        <span> {% trans "on" %} {{ attachment.device }}</span>

Tags: i18n
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129448

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/129448
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1eb0a6a711930f6deb6f807cf30e85baca671c33
Submitter: Jenkins
Branch: master

commit 1eb0a6a711930f6deb6f807cf30e85baca671c33
Author: Akihiro Motoki <email address hidden>
Date: Sun Oct 19 07:48:21 2014 +0900

    Remove string concatenation related to volume attachment

    Translatable string "on" is a part of string concatenation
    and it makes difficult to translate it properly.

    Change-Id: Ib2bf65791899a3c69087749d3a5fcf5061568b5d
    Closes-Bug: #1382874

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.