AutoDJ starts Decks play while Deck 3+4 playing

[Michael S.]

Mixxx 1.12 alpha Build 4720, W7/64
I have tested something that belongs deck 3&4, both played, fader left. Deck 1&2 are empty. (then i wanted to made a coffe breake hi i)
I pressed AutoDJ activate. Then deck 1&2 was loaded and deck 1 began to play. Not good, sorry! So i hear deck 1 and 3 playing....

[Daniel Schürmann (daschuer)]

Yes, AudoDJ does not care about Deck 3 and 4.
Do you have time and fun to look at it yourself?

It is around here https://github.com/mixxxdj/mixxx/blob/master/src/dlgautodj.cpp#L271
Just ask if you need help.

[Michael S. (arbeit-u)]

I am not so good in coding (today). Sorry. I think about. Perhaps, later? ;-)

In moment i completly renew my little project "MIDI for Light". Making the MIDI Controller smaler, faster and better for 1.12 and the 4 decks.
A Midi controller for light controlling. And (i am so bright to say) with midi-timecode-output.
I don't understood that a controller (like this) is not in MIXXX per default. Music without good light which is beat sync and so on....nothing for me.

[Owen Williams (ywwg)]

Maybe as part of enabling auto DJ we can just gradually move the gain sliders for decks 3 and 4 to zero

[Daniel Schürmann (daschuer)]

Mmm, I think this is not what the DJ and the audience expects.
We have already a Popup message when Deck 1 and Deck 2 are in playing and Auto DJ is enabled.
So as a band aid, we may add a message here as well.
It would be best, when the AutoDJ fades to Deck 1 from Deck 3 or 4 when almost finished.

[Owen Williams (ywwg)]

https://github.com/mixxxdj/mixxx/pull/360

[Michael S. (arbeit-u)]

@owen:
Thanks for nice look on the work. Is it correct that volume down deck 3&4 starts immediatley? If yes: I think its better to wait at the correct moment. The moment is when the normale fade over starts normaly (depending at autodj songending - fadetime).

[Owen Williams (ywwg)]

Totally ugly fix committed. I'll file a feature request to handle this more gracefully.

https://github.com/mixxxdj/mixxx/commit/c3fef8ed8bc5afe5a89142107c9ec1d121d407d2

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7609