Tab bar is unnecessary in detail pages with a single tab

Bug #1382546 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Thai Tran

Bug Description

Tab bar is used even when a detail page has only one tab. It is unnecessary.

Tab styling is now improved in https://review.openstack.org/#/c/128247/ and once this is merged, the tab bar in a detail page with a single tab maybe be a bit surprising.

Red square in the attached image is an example.
(Note that Blue square in the image is a different issue but it needs to be improved too.)

Revision history for this message
Akihiro Motoki (amotoki) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129449

Changed in horizon:
status: New → In Progress
Changed in horizon:
assignee: Akihiro Motoki (amotoki) → Thai Tran (tqtran)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/129449
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4668dc4548e72accefe8d08c0de547fb8709c544
Submitter: Jenkins
Branch: master

commit 4668dc4548e72accefe8d08c0de547fb8709c544
Author: Akihiro Motoki <email address hidden>
Date: Mon Oct 20 06:55:54 2014 +0900

    Allow to hide tab title bar when only one tab is available

    In detail pages with a single tab, tab title bars are redundant
    and unnecessary. For such pages, it would be nice if a tab bar
    is hidden.

    This commit introduces show_single_tab attribute to TabGroup
    class. The default value is set to False because hiding a tab bar
    for a single tab page looks appropriate in most cases.

    Tab mechanism makes developers to add new tabs for extensibility.
    If we remove tab view and change such view into a normal DetailView
    we will lose the extensibility. After discussion with some Horizon
    developers, it sounds nice to hide tab bar for a single tab page.

    Closes-Bug: #1382546
    Change-Id: I90276c531d0a017e3970b48290ae730ea3f1ecad

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.