"tox -e pep8" unnecessarily uses bash

Bug #1382327 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
YAMAMOTO Takashi

Bug Description

sh is hopefully more ubiquitously available than bash.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129120

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

and where would that a problem in practice?

Changed in neutron:
status: In Progress → Incomplete
Changed in neutron:
status: Incomplete → In Progress
Changed in neutron:
importance: Undecided → Low
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/129120
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9ffa8bd9e7ecc3de8301d8854316c01e1e55e0dd
Submitter: Jenkins
Branch: master

commit 9ffa8bd9e7ecc3de8301d8854316c01e1e55e0dd
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Oct 17 12:30:38 2014 +0900

    tox.ini: Avoid using bash where unnecessary

    Switch to sh, which is hopefully more ubiquitously available than bash.

    A recent change (commit 085a35d657cf0fa41a402f2af66c4beaa0f60db2)
    introduced bash dependency for "tox -e pep8". It broke my environment,
    where bash is not available. This change aims to restore it.
    As far as I undestand, the change in question doesn't actually need
    the specific shell dialect. So switch to sh, which is expected to be
    available for any POSIX-like systems, would improve the situation.

    Closes-Bug: #1382327
    Change-Id: Ie023d2265d9949a3e3721f03e865e4acfb460de2

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.