SwiftSignalHandle doesn't correctly handle deletes for missing resources

Bug #1382226 reported by Randall Burt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Randall Burt

Bug Description

SwiftSignalHandle throws an exception if it attempts to delete an object that had previously been deleted out-of-band. The offending code is:

if sc.is_not_found(exc)

when sc is the actual client rather than the client plugin. This prevents a stack from being deleted.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129345

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/129345
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e83f785ece70755a65dd736d9f213255a8a3d376
Submitter: Jenkins
Branch: master

commit e83f785ece70755a65dd736d9f213255a8a3d376
Author: Randall Burt <email address hidden>
Date: Fri Oct 17 12:59:57 2014 -0500

    Use correct object when deleting

    SwiftSignalHandle was using the client object instead
    of the client plugin object to check for Not Found
    during delete. Also normalized access to the client
    and plugin as well as remove a few pep8 warning items.

    Change-Id: Ib73cb3846feb6ccb2e45859458008a1701aa2231
    Closes-Bug: #1382226

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.