Tags overlap the date in the notes list
Bug #1382176 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Notes app |
Fix Released
|
High
|
Riccardo Padovani | ||
Bug Description
If a note has several tags, they overlap the date text on the notes list.
We might want to have a fixed width for the section where tags appear and ellipsize them if they are longer than the allowed space.
Related branches
lp:~rpadovani/reminders-app/1382176
- Michael Zanetti (community): Disapprove
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 46 lines (+11/-17)1 file modifiedsrc/app/qml/components/NotesDelegate.qml (+11/-17)
lp:~mzanetti/reminders-app/offline-mode
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Nicholas Skaggs (community): Needs Fixing
-
Diff: 6031 lines (+3029/-938)68 files modified3rdParty/libthrift/CMakeLists.txt (+1/-1)
CMakeLists.txt (+5/-1)
debian/control (+4/-1)
manifest.json.in (+4/-0)
push-helper.apparmor (+11/-0)
push-helper.json (+3/-0)
reminders.apparmor (+5/-2)
src/CMakeLists.txt (+2/-0)
src/app/preferences.cpp (+10/-0)
src/app/preferences.h (+5/-0)
src/app/qml/components/EditTagsDialog.qml (+3/-8)
src/app/qml/components/NotebooksDelegate.qml (+95/-78)
src/app/qml/components/NotesDelegate.qml (+51/-53)
src/app/qml/components/PageWithBottomEdge.qml (+4/-1)
src/app/qml/components/RemindersDelegate.qml (+67/-56)
src/app/qml/components/StatusBar.qml (+42/-0)
src/app/qml/components/TagsDelegate.qml (+72/-60)
src/app/qml/reminders.qml (+157/-73)
src/app/qml/ui/AccountSelectorPage.qml (+16/-3)
src/app/qml/ui/EditNoteView.qml (+8/-0)
src/app/qml/ui/NotePage.qml (+3/-8)
src/app/qml/ui/NoteView.qml (+0/-6)
src/app/qml/ui/NotebooksPage.qml (+4/-13)
src/app/qml/ui/NotesPage.qml (+9/-18)
src/app/qml/ui/RemindersPage.qml (+1/-0)
src/app/qml/ui/SetReminderView.qml (+53/-27)
src/app/qml/ui/TagsPage.qml (+1/-0)
src/libqtevernote/CMakeLists.txt (+2/-1)
src/libqtevernote/evernoteconnection.cpp (+35/-17)
src/libqtevernote/evernoteconnection.h (+3/-6)
src/libqtevernote/jobs/createnotebookjob.cpp (+9/-5)
src/libqtevernote/jobs/createnotebookjob.h (+5/-3)
src/libqtevernote/jobs/createnotejob.cpp (+27/-15)
src/libqtevernote/jobs/createnotejob.h (+4/-5)
src/libqtevernote/jobs/createtagjob.cpp (+8/-5)
src/libqtevernote/jobs/createtagjob.h (+5/-3)
src/libqtevernote/jobs/evernotejob.cpp (+112/-49)
src/libqtevernote/jobs/evernotejob.h (+2/-0)
src/libqtevernote/jobs/savenotebookjob.cpp (+8/-7)
src/libqtevernote/jobs/savenotebookjob.h (+2/-1)
src/libqtevernote/jobs/savenotejob.cpp (+56/-45)
src/libqtevernote/jobs/savetagjob.cpp (+8/-7)
src/libqtevernote/jobs/savetagjob.h (+2/-1)
src/libqtevernote/note.cpp (+197/-37)
src/libqtevernote/note.h (+41/-9)
src/libqtevernote/notebook.cpp (+142/-8)
src/libqtevernote/notebook.h (+44/-5)
src/libqtevernote/notebooks.cpp (+41/-0)
src/libqtevernote/notebooks.h (+8/-1)
src/libqtevernote/notes.cpp (+23/-1)
src/libqtevernote/notes.h (+6/-0)
src/libqtevernote/notesstore.cpp (+922/-253)
src/libqtevernote/notesstore.h (+50/-11)
src/libqtevernote/resource.cpp (+4/-3)
src/libqtevernote/tag.cpp (+157/-16)
src/libqtevernote/tag.h (+45/-7)
src/libqtevernote/tags.cpp (+45/-0)
src/libqtevernote/tags.h (+8/-1)
src/libqtevernote/userstore.cpp (+9/-4)
src/libqtevernote/userstore.h (+1/-1)
src/libqtevernote/utils/enmldocument.cpp (+2/-2)
src/libqtevernote/utils/organizeradapter.cpp (+172/-0)
src/libqtevernote/utils/organizeradapter.h (+40/-0)
src/push-helper/CMakeLists.txt (+26/-0)
src/push-helper/core.cpp (+60/-0)
src/push-helper/core.h (+25/-0)
src/push-helper/main.cpp (+32/-0)
tests/autopilot/reminders/tests/test_reminders.py (+5/-0)
| Changed in reminders-app: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in reminders-app: | |
| milestone: | none → 2014-11-13 |
| Changed in reminders-app: | |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
Revision history for this message
| Michael Zanetti (mzanetti) wrote | #1 |
| Changed in reminders-app: | |
| milestone: | 2014-11-13 → 2014-11-27 |
| Changed in reminders-app: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in reminders-app: | |
| status: | In Progress → Fix Committed |
| Changed in reminders-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm afraid we have a design issue here:
I there is a note with an image and tags, there's no way we can fit all of it in the bottom line of the delegate. My suggestion would be to move the date into the tagline text and leave the delegate bottom row for tags.