Replace use of <center> tag in RouterRules Grid template

Bug #1381574 reported by Chad Roberts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Swati Sharma

Bug Description

In openstack_dashboard/dashboards/project/routers/templates/routers/extensions/routerrules/grid.html the <center> tag is used. As discussed in https://review.openstack.org/#/c/126141/10 the <center> tag should be stripped and the formatting should be handled via CSS.

Revision history for this message
Sergey Gotliv (sgotliv) wrote :

Tag <center> is deprecated in HTML 4.0 and totally not-supported in HTML 5.0. I agree that it should be replaced with appropriate CSS style.

Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

+1 Fortunately <center> is still supported by all major browsers, per http://www.w3schools.com/tags/tag_center.asp

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
Changed in horizon:
assignee: nobody → Swati Shukla (swati-shukla1)
Changed in horizon:
status: Confirmed → In Progress
summary: - Remove use of <center> tag in template
+ Replace use of <center> tag in RouterRules Grid template
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146059

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/146059
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c849869959806cf58e56657e852e9458ba07d34c
Submitter: Jenkins
Branch: master

commit c849869959806cf58e56657e852e9458ba07d34c
Author: swati <email address hidden>
Date: Fri Jan 9 06:31:51 2015 -0500

    Replace use of <center> tag in RouterRules Grid template

    In "openstack_dashboard/dashboards/project/routers/templates/"..
    ..routers/extensions/routerrules/grid.html", the <center> tag is
    used. This should be stripped and the formatting should be
    handled via CSS.

    Change-Id: I42437a4db34a5b1d3c49d48edcc0f1c996766a38
    Closes-Bug: #1381574

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.