Unit test failure "AssertionError: Expected to be called once. Called 2 times." in test_get_port_vnic_info_3

[Hans Lindgren]

This looks to be due to tests test_get_port_vnic_info_2 and 3 sharing some code and is easily reproduced by running these two tests alone with no concurrency.

./run_tests.sh --concurrency 1 test_get_port_vnic_info_2 test_get_port_vnic_info_3

The above always results in:

Traceback (most recent call last):
  File "/home/hans/nova/nova/tests/network/test_neutronv2.py", line 2615, in test_get_port_vnic_info_3
    self._test_get_port_vnic_info()
  File "/home/hans/nova/.venv/local/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/home/hans/nova/nova/tests/network/test_neutronv2.py", line 2607, in _test_get_port_vnic_info
    fields=['binding:vnic_type', 'network_id'])
  File "/home/hans/nova/.venv/local/lib/python2.7/site-packages/mock.py", line 845, in assert_called_once_with
    raise AssertionError(msg)
AssertionError: Expected to be called once. Called 2 times.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128589

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128589
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f91d4ebeac9181ff279158fe89a8d50b34184a89
Submitter: Jenkins
Branch: master

commit f91d4ebeac9181ff279158fe89a8d50b34184a89
Author: Hans Lindgren <email address hidden>
Date: Wed Oct 15 11:16:03 2014 +0200

    Fix unit test failure due to tests sharing mocks

    A recent refactor made test_get_port_vnic_info 2 and 3 share code
    in a private method _test_get_port_vnic_info(). A mock on this method
    is shared between the tests and can cause the following failure:

    AssertionError: Expected to be called once. Called 2 times.

    This is changed so that the two test methods create separate mocks and
    pass to the shared method.

    Change-Id: I3902b7b7cf4b4b3fdc2885bf2611a712d008c617
    Closes-Bug: #1381414

[Nikola Đipanov (ndipanov)]

I am really surprised this is not hitting stable-juno gate as it seems like it will happen 100% of the time when these 2 tests are run in the same worker?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/146901

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146901
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4349015b26cc4df965595b6f1175be57ccc7eda2
Submitter: Jenkins
Branch: stable/juno

commit 4349015b26cc4df965595b6f1175be57ccc7eda2
Author: Hans Lindgren <email address hidden>
Date: Wed Oct 15 11:16:03 2014 +0200

    Fix unit test failure due to tests sharing mocks

    A recent refactor made test_get_port_vnic_info 2 and 3 share code
    in a private method _test_get_port_vnic_info(). A mock on this method
    is shared between the tests and can cause the following failure:

    AssertionError: Expected to be called once. Called 2 times.

    This is changed so that the two test methods create separate mocks and
    pass to the shared method.

    Change-Id: I3902b7b7cf4b4b3fdc2885bf2611a712d008c617
    Closes-Bug: #1381414
    (cherry picked from commit f91d4ebeac9181ff279158fe89a8d50b34184a89)